Repository navigation
Handle Appointment roles - #1348
Merged
Merged
Conversation
This is only populated if Asset has an appointments role, this avoids bloating the cached OrchestrationAsset when it will seldom be used
Number1-3 will always be passed as it is not-null in DB so we can't distinguish between valid and invalid 0. String1-3 only passed if there is a value.
donaldgray
force-pushed
the
feature/appointment_role
branch
from
November 10, 2026 13:48
f9a77b0 to
7c6a042
Compare
JackLewis-digirati
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Orchestrator support for the
Appointmentrole-provider added to iiif-auth-v2 (see the dlcs/iiif-auth-v2#69). All roles will haveappointment:prefix. Orchestrator uses this naming convention to determine how it needs to call iiif-auth-v2.OrchestrationAssets with a
appointment:*role will have full metadata populated as iiif-auth-v2 requires this to make a decision. The inclusion of this role is used as it'll be a much smaller set of assets and avoids bloating all assets in orchestrator cache. Adjuncts use Asset parent role for same thing.For appointment roles
/verifyaccess/and/probe_internal/requests POST rather than GET to specify the additional fields. Non-null fields are passed. Number1-3 are always passed as we don't have nulls and can't distinguish between valid and invalid0.Note
Requires iiif-auth-v2 that supports POST endpoints. (assuming v1.4.0)
Resolves #1346