Repository navigation
Remove Autocomplete and just rely on Search - #78
Conversation
How this worksResolves #74. IIIF only defines autocomplete as a service nested inside a search service, so autocomplete can't be advertised in a Manifest on its own. This PR removes the Before
After1. The 2.
3. The text-augmented Manifest always nests autocomplete inside search. The search services are still only added when
For example, a job with "service": [
{
"id": "https://example.org/search/v2/my-book",
"type": "SearchService2",
"service": [
{ "id": "https://example.org/autocomplete/v2/my-book", "type": "AutoCompleteService2" }
]
},
{
"id": "https://example.org/search/v1/my-book",
"type": "SearchService1",
"profile": "http://iiif.io/api/search/1/search",
"service": [
{ "id": "https://example.org/autocomplete/v1/my-book", "type": "AutoCompleteService1", "profile": "http://iiif.io/api/search/1/autocomplete" }
]
}
]Existing jobs
Docs
Tests
|
d809f50 to
4857511
Compare
donaldgray
left a comment
There was a problem hiding this comment.
LGTM - both the ## How this works and linked ticket read like we still support Autocomplete, rather than having removed it.
These should both be updated.
ea7041c to
e550099
Compare
What does this change?
Resolves #74
This PR makes it so that jobs will automatically receive autocomplete whenever
Searchis asked for. Secondly, asSearchnow givesAutocomplete, this value has been retired and will be ignored if it's asked for