Repository navigation
Preserve configuration during interrupted saves - #4
Merged
Merged
Conversation
lukisch
commented
Oct 3, 2026
lukisch
left a comment
Collaborator
Author
There was a problem hiding this comment.
Zweitmodell-Review: CI grün (12/12, Windows/macOS/Linux), keine Blocker.
config.save() schreibt nun über NamedTemporaryFile im Konfigurationsordner und os.replace; ein Fehler lässt die bisherige Konfiguration unberührt, der ursprüngliche Fehler wird nicht durch Aufräumfehler verdeckt. Zwei Tests (Teilwrite, Replace-Fehler) belegen das. requirements-dev.txt und der tomllib-Fallback sind sauber. Keine Credentials oder Nutzerpfade im Diff.
Hinweise:
- Kein
fsyncvorreplace(Schutz gegen Prozessabbruch, nicht gegen Stromausfall). NamedTemporaryFileerzeugt Modus 0600; die Konfiguration erhält dadurch nach dem Speichern 0600 (bei Konfigurationen mit Tool-Pfaden/Accounts eher ein Vorteil, aber eine Verhaltensänderung).- Bei hartem Abbruch bleiben
.mp-*.tmpim Konfigurationsordner liegen.
Generated by Claude Code
lukisch
marked this pull request as ready for review
October 3, 2026 21:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--self-testpath that verifies the bundled icon, tray menu, and rendered settings dialog with a synthetic configuration, without loading user configuration or running setup, autostart, scanning, or downloads.requirements-dev.txt, use them in CI and contributor setup, and provide thetomlifallback required by the Python 3.10 test matrix.Validation
python -B -m pytest -q -p no:cacheprovider— 102 passed, 6 subtests passed (Python 3.12.10; isolated scratch profile).ruff check .— passed.python -B -m compileall -q .— passed.git diff --check— passed.MailProcessor.exe --self-testexited 0 with an isolated offscreen profile. Artifact SHA-256:268CEA2B8F5D6BDAAAA3F8DB71F230AE1174B08BA179EB419FCCAF90B1C8138E.