Repository navigation
fix: validate tool download destination before network - #6
Merged
Merged
Conversation
Signed-off-by: Lukas Geiger <[email protected]>
lukisch
marked this pull request as ready for review
October 3, 2026 22:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
download_tool()contacted GitHub for release metadata before checking whether the local destination was usable. A regular file or a destination whose metadata check raisesOSErrorcould therefore produce a network error instead of the local destination error.This change checks the destination and existing parents before any network request, keeps the existing
Download error: cannot prepare destination:prefix, and leaves existing destination contents untouched. The latermkdirremains as the race-time guard.Validation
tests/test_tool_manager.py: 26 passed.git diff --check: passed.