Repository navigation
fix genexample appending keys to the last line of .env.example - #1051
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
dotenvx ext genexamplenow adds a newline before it appends missing keys to an existing.env.examplethat does not end with a newline.Why
If
.env.examplehas no trailing newline, the first new key goes onto the last existing line. For example,HELLO=''becomesHELLO=''HELLO2=''. The new key is lost and the existing value is changed.Fixes #1050
How to test
The new test
#run (.env.example already exists without trailing newline)fails without the change and passes with it. The preceding test now restores itsreadFileXSyncstub so the new test can stub the same method.