Repository navigation
Avoid double int casts when shifting by C++ enumerators - #857
Merged
tannergooding merged 1 commit intoNov 14, 2026
Merged
Conversation
Co-authored-by: Copilot App <[email protected]>
tannergooding
force-pushed
the
tannergooding-fix-shift-double-cast
branch
from
November 14, 2026 22:49
1bba0ac to
5064886
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
C++ enumerator shift counts already emit an
intcast through implicit integral promotion. Avoid adding a second cast in the shift visitor, while preserving the explicit cast required for C enumerators and enum initializers.Add regression coverage for shifts by enumerators and bump the managed package version to
23.1.5.1.