Repository navigation
perf(sm120): reduce DeepSeek-V4.1 prefill overhead - #1793
Merged
Merged
Conversation
Honor the configured row threshold, preserve global metadata offsets, and gather ragged selected-index shards before attention. Keep pure decode, capture, and the wide candidate producer on their existing paths. Document the existing nondeterministic boundary-tie selection policy rather than promising bit-identical production indices. Signed-off-by: AlpinDale <[email protected]>
Signed-off-by: AlpinDale <[email protected]>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Signed-off-by: AlpinDale <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable sharding with
indexer_tp_shard_min_rows=2048. Depends on #1788.Attention update benchmarks
29cfe09f43→01f4bebe90, TP4 on 4× RTX PRO 6000 Blackwell Server GPUs; MNBT 4096, DSpark K7, paired P2P, max context 262,144, max sequences 8, capture 64, shard threshold 2048.Fresh ABBA comparison; two servers per variant, six measured batches per cell; warmups excluded. Throughputs are aggregate medians. TTFT pools 6/48 requests at C=1/C=8 (nearest-rank p95).
Prefill uses fresh prompts with one output token. TTFT/cold output use separate fresh prompts with 2048 output tokens. Steady decode uses cached prompts and exact token IDs in the common-active window; all full generations ignore EOS.
DSpark acceptance varies across repeats; token/s changes are not isolated kernel-speed measurements.
Frozen attention replays remain bit-exact; 28 focused GPU tests and type checks for Python 3.11–3.13 pass.
Earlier MNBT sweep (29cfe09)
MNBT 4096 gave the best prefill rates in that sweep; other budgets were not rerun for the attention update.