Repository navigation
Conversation
Signed-off-by: AlpinDale <[email protected]>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Signed-off-by: AlpinDale <[email protected]>
Signed-off-by: AlpinDale <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Through the NF12 package, this PR adds support for losslessly compressing BF16 models to roughly 12-bits, inspired by the NyoomFloat12 paper.
Throughput
Tested on an RTX PRO 6000 Blackwell Server Edition:
Memory savings
Use by loading a normal BF16 model and adding
--quantization nf12orquantization="nf12"if using the python API.KL divergence
KL(BF16 || NF12), WikiText-2,
The reason why the agreement isn't 100% is because NF12 and BF16 in Sonar use different execution pipelines, so small numerical differences accumulate. NF12 guarantees lossless weight compression. Any lossless guarantees on the output tokens needs to be implemented on the execution side. Regardless, the difference is so minuscule and variant from run-to-run that it doesn't matter.