Repository navigation
Feature #591 remove unused dependencies - #592
Merged
Merged
Conversation
None of these packages are imported by METplotpy. imutils and eofs were carried over from a requirements list shared with METcalcpy, and pint is installed as a dependency of metpy. Co-Authored-By: Claude Opus 5.5 <[email protected]>
- Remove the process-wide warnings.filterwarnings("error") from
ROCDiagramSeries. It was added only so test_pct_no_warnings could detect
FutureWarnings, but it turned every later warning into an exception, which
broke the ROC tests when pandas 3.1 added new deprecation warnings. The
test now scopes the check with pytest.mark.filterwarnings.
- Taylor diagram: pass apply_theta_transforms=False to PolarTransform so
Matplotlib 3.10 does not warn on creation or inversion, and ignore the
one-time warning Matplotlib 3.11 gives for passing the argument.
- Remove the deprecated float_precision argument from read_csv calls.
- Replace inplace= calls with reassignment (PDEP-8).
- Remove the mode.chained_assignment option, which has no effect since
pandas 3.0.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
The pandas<3 pin for the Python 3.12 job was overridden by pandas>=3.0.2 in the requirements files. Instead, install the minimum versions listed in the METplotpy and METcalcpy requirements files for Python 3.12, while Python 3.14 continues to install the latest versions. Co-Authored-By: Claude Opus 5.5 <[email protected]>
bikegeek
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Describe the changes proposed by this pull request:
Resolves #591.
imutils,eofsandpintfromrequirements.txt(andpintfromnco_requirements.txt). None are imported by METplotpy;pintis still installed as a dependency ofmetpy.warnings.filterwarnings("error")fromROCDiagramSeries. It was only there fortest_pct_no_warnings, which now usespytest.mark.filterwarnings("error::FutureWarning")instead. This fixes the 8 ROC diagram failures with pandas 3.1.apply_theta_transforms=FalsetoPolarTransformso Matplotlib 3.10 does not warn on creation or inversion, and ignore only the one-time warning Matplotlib 3.11 gives for passing the argument. A comment notes that both can be removed once the minimum Matplotlib is 3.11.float_precision='round_trip'fromread_csvcalls, replaceinplace=calls with reassignment, and remove themode.chained_assignmentoption, which has had no effect since pandas 3.0.pandas<3pin was overridden bypandas>=3.0.2in the requirements files. The job now installs the minimum versions listed in the METplotpy and METcalcpy requirements files, and the Python 3.14 job still installs the latest versions.Pull Request Testing
Describe testing already performed for these changes:
Ran the full pytest suite locally in the v13.0 conda environment (Python 3.14, pandas 3.0.2, Matplotlib 3.10.8): 62 passed, 21 skipped, no warnings from METplotpy code. Before these changes, the 3 Taylor diagram tests failed locally, and the 8 ROC diagram tests failed in GitHub Actions with pandas 3.1.0.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Review the GitHub Actions results for both Python versions. The Python 3.12 job prints the pinned minimum versions in the "Install dependencies" step. Remaining warnings from METcalcpy (
sort_by_thresh,_calc_pct_roc,event_equalize) and from metpy'sskewt.pyare expected until those packages are updated.Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No] The weather regime and TC RMW docs still list
eofsandpintas prerequisites.Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
No changes to output are expected. Removing
float_precision='round_trip'makes no difference on pandas 3.1, but on pandas 3.0.x parsed floats could differ in the last digit.Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by 10/28/2026.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases and/or METplus-X.Y Development project for the next coordinated release
🤖 Generated with Claude Code