Repository navigation
docs(analyzers): record three candidates and queue follow-ups - #181
Merged
Merged
Conversation
Read the BlazingFastDotnet guide a fourth time against the shipped rule set. Three shapes clear the bar: the Func<Task> middleware delegate, UseStaticFiles, and string.Split used only to enumerate. Four shapes already have an installed owner and move to the skipped file. Three Tier 2 shapes wait on a defect in review. Split the guidance-document history out of catalog.md into guidance-reads.md so both files stay under the line limit. Add every candidate, its score, and its code fix to plans/roadmap.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executive Summary
Checked the BlazingFastDotnet performance skill guide against the shipped E128 rule set and the installed analyzers. Three shapes have no owner and enter the register: the
Func<Task>middleware delegate,UseStaticFiles, andstring.Splitused only to enumerate. Four shapes already report through IDE0320, IDE0330, or a built-in ASP.NET Core analyzer, so they are recorded as declined. No rule ships in this change.Code Changes
lode/dotnet/analyzer-candidates/index.md: threenewrows at 4/5, 4/5, and 3.5/5, each with a detection note and a fix shape. Three Tier 2 rows added. The rubric pointer now names the agent definition that holds the rubric.lode/dotnet/analyzer-candidates/guidance-reads.md: new file. Holds the four reads of the two guidance documents, the rows that stay a document, and the extension notes. The split keeps this file andcatalog.mdunder the 250-line limit.lode/dotnet/analyzer-candidates/catalog.md: drops the guidance history that the new file now owns, and keeps the ID map.lode/dotnet/analyzer-candidates/skipped-decisions.md: table of the shapes that already carry an installed owner.plans/roadmap.md: five active entries and three waiting entries. Each carries the shape, the score, the before and after code fix, and the condition that makes the fix wrong.Tests and Tooling
scripts/lode-check.shon every changed Lode file: clean. The remaining hits are C# semicolons inside code blocks, which sit outside the prose scope..csfile changed.scripts/internal/analyzer-release-check.sh --json: clean, 223 source IDs, no missing, duplicate, or orphan row.scripts/readme-table-diff.sh --analyzer --json: no drift.scripts/internal/precommit.sh: clean.Review Guide
newrows clear the bar. Every fix changes allocation or I/O behavior, and none changes program output.guidance-reads.mdsplit: confirmcatalog.mdkeeps what a later session needs for ID reuse.Rollback
Revert the commit. No code, configuration, or published rule changes.