Skip to content

docs(analyzers): record three candidates and queue follow-ups - #181

Merged
e128 merged 1 commit into
mainfrom
refactor/analyzer-candidate-queue
Nov 17, 2026
Merged

e128 merged 1 commit into
mainfrom
refactor/analyzer-candidate-queue

Conversation

@e128

@e128 e128 commented Nov 17, 2026

Copy link
Copy Markdown
Owner

Executive Summary

Checked the BlazingFastDotnet performance skill guide against the shipped E128 rule set and the installed analyzers. Three shapes have no owner and enter the register: the Func<Task> middleware delegate, UseStaticFiles, and string.Split used only to enumerate. Four shapes already report through IDE0320, IDE0330, or a built-in ASP.NET Core analyzer, so they are recorded as declined. No rule ships in this change.

Code Changes

  • lode/dotnet/analyzer-candidates/index.md: three new rows at 4/5, 4/5, and 3.5/5, each with a detection note and a fix shape. Three Tier 2 rows added. The rubric pointer now names the agent definition that holds the rubric.
  • lode/dotnet/analyzer-candidates/guidance-reads.md: new file. Holds the four reads of the two guidance documents, the rows that stay a document, and the extension notes. The split keeps this file and catalog.md under the 250-line limit.
  • lode/dotnet/analyzer-candidates/catalog.md: drops the guidance history that the new file now owns, and keeps the ID map.
  • lode/dotnet/analyzer-candidates/skipped-decisions.md: table of the shapes that already carry an installed owner.
  • plans/roadmap.md: five active entries and three waiting entries. Each carries the shape, the score, the before and after code fix, and the condition that makes the fix wrong.

Tests and Tooling

  • scripts/lode-check.sh on every changed Lode file: clean. The remaining hits are C# semicolons inside code blocks, which sit outside the prose scope.
  • Build and test not run: no .cs file changed.
  • scripts/internal/analyzer-release-check.sh --json: clean, 223 source IDs, no missing, duplicate, or orphan row.
  • scripts/readme-table-diff.sh --analyzer --json: no drift.
  • scripts/internal/precommit.sh: clean.

Review Guide

  • Whether the three new rows clear the bar. Every fix changes allocation or I/O behavior, and none changes program output.
  • The guidance-reads.md split: confirm catalog.md keeps what a later session needs for ID reuse.

Rollback

Revert the commit. No code, configuration, or published rule changes.

Read the BlazingFastDotnet guide a fourth time against the shipped rule
set. Three shapes clear the bar: the Func<Task> middleware delegate,
UseStaticFiles, and string.Split used only to enumerate. Four shapes
already have an installed owner and move to the skipped file. Three
Tier 2 shapes wait on a defect in review.

Split the guidance-document history out of catalog.md into
guidance-reads.md so both files stay under the line limit.

Add every candidate, its score, and its code fix to plans/roadmap.md.
@e128
e128 merged commit a007d2d into main Nov 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant