Repository navigation
Conversation
vogella
force-pushed
the
vogella/filteredtree-reveal-selection
branch
from
October 14, 2026 21:27
96817cd to
56174c5
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Clearing a filter in quick-selection mode still leaves nested selections hidden.
1 open finding
What changed in this PR
Preserves selection visibility when a FilteredTree filter is widened or cleared.
Changes:
- Saves and reveals selections after refresh in both FilteredTree implementations.
- Adds regression tests for nested selections, repeated elements, and multiple selected paths.
| File | Description |
|---|---|
| tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/filteredtree/FilteredTreeTests.java | Adds selection-visibility regression tests. |
| bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/dialogs/FilteredTree.java | Restores selection visibility outside quick-selection mode. |
| bundles/org.eclipse.e4.ui.dialogs/src/org/eclipse/e4/ui/dialogs/filteredtree/FilteredTree.java | Restores selection visibility after widening filters. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vogella
force-pushed
the
vogella/filteredtree-reveal-selection
branch
from
October 15, 2026 05:53
56174c5 to
3dba775
Compare
vogella
force-pushed
the
vogella/filteredtree-reveal-selection
branch
2 times, most recently
from
October 15, 2026 17:12
80d2f2d to
8662852
Compare
Contributor
Author
|
Fixes the issue that e4 model looses its selection if the filter is removed 
|
vogella
force-pushed
the
vogella/filteredtree-reveal-selection
branch
from
October 16, 2026 18:38
8662852 to
4cf727a
Compare
Widening or clearing the filter collapses the whole tree, so the selected element ended up hidden inside a collapsed parent. Both FilteredTree implementations now reveal the selection again after the refresh, which also lets quick-selection mode keep a selection that still matches. Assisted-by: multiple AI agents and layers of automated tooling 🤖
vogella
force-pushed
the
vogella/filteredtree-reveal-selection
branch
from
October 16, 2026 18:58
4cf727a to
0690da6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widening or clearing the filter of a FilteredTree collapses the whole tree, so a selected element ends up hidden inside a collapsed parent and the user has to search for it again. Both the workbench and the e4 FilteredTree now remember the selection before the refresh and reveal it afterwards, re-selecting it only if the collapse dropped it. This fixes the behaviour for every client at once, including preference dialogs, the e4 model editor and the views that use FilteredTree, instead of each client working around it.