Skip to content

Add quick selection mode to the e4 FilteredTree - #4493

Open
vogella wants to merge 1 commit into
eclipse-platform:masterfrom
vogella:vogella/e4-filteredtree-quick-selection
Open

vogella wants to merge 1 commit into
eclipse-platform:masterfrom
vogella:vogella/e4-filteredtree-quick-selection

Conversation

@vogella

@vogella vogella commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

The workbench FilteredTree has a quick selection mode that selects the first match while the user types, which the Show View dialog relies on. The e4 FilteredTree lacked this mode, so e4 clients such as pure e4 RCP applications and the e4 tools could not get that behaviour without depending on the workbench. This adds setQuickSelectionMode() to the e4 FilteredTree and enables it in the e4 Show View dialog, so both dialogs behave the same.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Test Results

   578 files   -   289     578 suites   - 289   35m 17s ⏱️ - 24m 51s
 8 467 tests +    2   8 217 ✅  -     6  250 💤 +  8  0 ❌ ±0 
14 186 runs   - 7 087  13 722 ✅  - 6 868  464 💤  - 219  0 ❌ ±0 

Results for commit 85ac501. ± Comparison against base commit 3faf11c.

This pull request skips 8 tests.
org.eclipse.e4.ui.css.swt.helpers.CSSSWTFontHelperTest ‑ testGetFontDataWithIntermediateWeightDescribesThePangoWeight
org.eclipse.e4.ui.css.swt.helpers.CSSSWTFontHelperTest ‑ testGetFontDataWithRegularOrBoldWeightKeepsThePortableFont
org.eclipse.e4.ui.tests.css.swt.LabelTest ‑ testFontWeightSelectsThePangoWeightOnGtk
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testEnabledWhenHover(TestInfo)
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testMultipleHover(TestInfo)
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testProblemHover(TestInfo)
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testSingleHover(TestInfo)
org.eclipse.ui.genericeditor.tests.ShowInformationTest ‑ testInformationControl(TestInfo)

♻️ This comment has been updated with latest results.

The workbench FilteredTree can select the first match while the user
types, which the Show View dialog relies on, but the e4 FilteredTree had
no such mode. Add setQuickSelectionMode() to the e4 variant and enable
it in the e4 Show View dialog.

Assisted-by: multiple AI agents and layers of automated tooling 🤖
@vogella
vogella force-pushed the vogella/e4-filteredtree-quick-selection branch from 1c26f61 to 85ac501 Compare October 16, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant