Repository navigation
Conversation
Contributor
vogella
force-pushed
the
css-reapply-inherited-colors
branch
from
October 16, 2026 18:17
8311f3a to
32fce3f
Compare
CSSSWTColorHelper skipped setting a color when the control already reported it, but getBackground() also reports colors inherited from the parent. After a theme switch reset a control that owned a color, the new color was skipped whenever the parent had the same one, so the control owned no color. Children of a Forms Section then painted the Section's title gradient image. The helper now remembers that it applied a color and, after a reset, applies the new color even if it equals the inherited one. Controls that never owned a color keep inheriting, so the Section title label still shows the title bar. Element resets clear colors through the helper so the record stays accurate. Assisted-by: multiple AI agents and layers of automated tooling 🤖
vogella
force-pushed
the
css-reapply-inherited-colors
branch
from
October 16, 2026 18:25
32fce3f to
ac8a718
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a theme switch, CSSSWTColorHelper skipped setting a control's new background whenever the parent already had the same color, because getBackground() also reports inherited colors. The reset control then owned no color, and children of a Forms Section painted the Section's title gradient image instead, for example the white text fields in the PDE manifest editor after switching from Light to Dark. The helper now remembers the color it applied and only skips when the control really owns it, and the element resets clear colors through the helper. The existing optimization for unchanged colors stays in place for ordinary re-applies, and a regression test covers the reset case.