Skip to content

Remove the p2.inf that excludes darkest dark theme - #4511

Merged
merks merged 1 commit into
eclipse-platform:masterfrom
merks:pr-clean-jface.p2.inf
Oct 17, 2026
Merged

merks merged 1 commit into
eclipse-platform:masterfrom
merks:pr-clean-jface.p2.inf

Conversation

@merks

@merks merks commented Oct 17, 2026

Copy link
Copy Markdown
Contributor
  • Don't exclude com.genuitec.eclipse.theming.core.feature.feature.group version 2024.4.0.202412101111.
  • The current update site serves 2025.2.0.202509301431

- Don't exclude com.genuitec.eclipse.theming.core.feature.feature.group
version 2024.4.0.202412101111.
- The current update site serves 2025.2.0.202509301431
@merks

merks commented Oct 17, 2026

Copy link
Copy Markdown
Contributor Author

@vogella

FYI, installing darkest dark theme

image

in the 2026-09 release, results in an IDE that won't start, with this in the log:

!ENTRY org.eclipse.ui 2 0 2026-10-17 13:43:53.176
!MESSAGE Warnings while parsing the images from the 'org.eclipse.ui.commandImages' extension point.
!SUBENTRY 1 org.eclipse.ui 2 0 2026-10-17 13:43:53.176
!MESSAGE Cannot bind to an undefined command: plug-in='com.genuitec.eclipse.theming.ui', id='com.genuitec.myeclipse.help.darktheme.commandid'

!ENTRY org.eclipse.osgi 4 0 2026-10-17 13:43:53.370
!MESSAGE Application error
!STACK 1
java.lang.NoClassDefFoundError: org/eclipse/e4/ui/css/swt/engine/AbstractCSSSWTEngineImpl
	at org.eclipse.e4.ui.css.swt.internal.theme.ThemeEngineManager.getCSSSWTEngine(ThemeEngineManager.java:51)
	at org.eclipse.e4.ui.css.swt.internal.theme.ThemeEngineManager.getEngineForDisplay(ThemeEngineManager.java:40)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.createThemeEngine(PartRenderingEngine.java:1406)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.initializeStyling(PartRenderingEngine.java:1283)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1055)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1051)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153)
	at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:680)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:583)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:173)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:193)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:219)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:149)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:115)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:467)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:298)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:565)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:615)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:563)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1415)
Caused by: java.lang.ClassNotFoundException: org.eclipse.e4.ui.css.swt.engine.AbstractCSSSWTEngineImpl cannot be found by org.eclipse.e4.ui.css.swt_0.17.100.v20260730-1116
	at org.eclipse.osgi.internal.loader.BundleLoader.generateException(BundleLoader.java:570)
	at org.eclipse.osgi.internal.loader.BundleLoader.findClass0(BundleLoader.java:564)
	at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:439)
	at org.eclipse.osgi.internal.loader.ModuleClassLoader.loadClass(ModuleClassLoader.java:195)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:490)
	... 23 more

The same is true for 2026-12 staging.

Goodness knows what dark magic is being invoked. 😞

@github-actions

Copy link
Copy Markdown
Contributor

Test Results

   867 files  ±0     867 suites  ±0   47m 21s ⏱️ - 12m 47s
 8 465 tests ±0   8 223 ✅ ±0  242 💤 ±0  0 ❌ ±0 
21 273 runs  ±0  20 590 ✅ ±0  683 💤 ±0  0 ❌ ±0 

Results for commit 99206c5. ± Comparison against base commit 3faf11c.

@merks
merks merged commit c422230 into eclipse-platform:master Oct 17, 2026
18 checks passed
@merks
merks deleted the pr-clean-jface.p2.inf branch October 17, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant