Skip to content

Add "Preferences" entry to Terminal view menu - #2992

Merged
merks merged 1 commit into
eclipse-platform:masterfrom
SougandhS:terminal_preg
Oct 5, 2026
Merged

merks merged 1 commit into
eclipse-platform:masterfrom
SougandhS:terminal_preg

Conversation

@SougandhS

Copy link
Copy Markdown
Contributor

This PR adds a quick path to Preference page of Terminal similar to what Console view has.
eg. #2436

Screenshot 2026-10-05 at 12 57 43 PM

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Test Results

    54 files  ±0      54 suites  ±0   53m 15s ⏱️ - 3m 24s
 4 849 tests ±0   4 827 ✅ ±0   22 💤 ±0  0 ❌ ±0 
12 438 runs  ±0  12 284 ✅ ±0  154 💤 ±0  0 ❌ ±0 

Results for commit 522f5be. ± Comparison against base commit 8fa7d88.

♻️ This comment has been updated with latest results.

@merks merks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a nice idea and I only have a nitty suggestion on the tool tip..

Comment thread terminal/bundles/org.eclipse.terminal.view.ui/plugin.properties Outdated
@SougandhS
SougandhS force-pushed the terminal_preg branch 3 times, most recently from c06b70c to 3f2b30b Compare October 5, 2026 11:41

@merks merks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are really superficial comments...

It's up to you if you want to change that....

Comment thread terminal/bundles/org.eclipse.terminal.view.ui/plugin.xml Outdated
This commit adds a quick path to Preference page of Terminal similar to
what Console view has.
@SougandhS

Copy link
Copy Markdown
Contributor Author

It's up to you if you want to change that....

Updated 👍

@SougandhS

Copy link
Copy Markdown
Contributor Author

Hi @merks,
build looks good now can u merge this ?

@merks
merks merged commit d5a6f21 into eclipse-platform:master Oct 5, 2026
18 checks passed
@SougandhS

Copy link
Copy Markdown
Contributor Author

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants