Repository navigation
Conversation
a-zw
requested review from
AlexanderLanin,
MaximilianSoerenPollak,
dcalavrezo-qorix and
nradakovic
as code owners
November 3, 2026 16:35
This was referenced Nov 3, 2026
Contributor
|
Documentation preview for this pull request is available at: |
There was a problem hiding this comment.
🟡 Changes recommended
The changed mitigation rule lacks regression tests against the actual metamodel for QM versus ASIL_B Assumption of Use mitigation and platform DFA cases, leaving key behavior changes undetected.
1 open issue
What changed in this PR
This PR corrects the metamodel’s informational mitigated_by check for valid safety analyses.
Changes:
- Requires an ASIL_B mitigation target, removing the exemption for Assumption of Use requirements.
- Includes platform DFA in the check and updates its explanation.
- Refreshes the generated HTML fixture’s metamodel line count.
| File | Description |
|---|---|
| src/tests/docs_bzl/scenarios/reference_integration/_expected/docs/modules/modern_module/components/unlinked_component/generated_metamodel/index.html | Updates the expected source line count from 1334 to 1332. |
| src/extensions/score_metamodel/metamodel.yaml | Corrects the mitigation condition and extends coverage to platform DFA. |
Review effort: Balanced
| - safety == ASIL_B | ||
| - type == aou_req | ||
| explanation: Valid safety analyses should link to at least one same-level or higher-safety requirement, or an Assumption of Use requirement. | ||
| safety == ASIL_B |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
The check interpreted the requirement incorrectly.
🚨 Impact Analysis
✅ Checklist