Skip to content

[enh] Harmonize SysML icons and action diagram node palette - #2555

Merged
gcoutable merged 1 commit into
mainfrom
meb/enh/semantic-icon-palette
Oct 16, 2026
Merged

gcoutable merged 1 commit into
mainfrom
meb/enh/semantic-icon-palette

Conversation

@mbats

@mbats mbats commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

This PR harmonizes the semantic icon palette and action diagram node rendering across SysON:

  • Recolors the SysML obj16 icons with the semantic palette and optimizes the SVGs with SVGO.
  • Adds dedicated parameter* icons for explorer and parameter compartment creation tools.
  • Adds dedicated parameter_in, parameter_out, and parameter_inout SVGs for ReferenceUsage parameter border nodes.
  • Harmonizes action diagram node images and Fork/Join node colors.

Visual Preview

Icon | Before | After - header | After - compartment

Exact HTML comparison, part 1

Exact HTML comparison, part 2

Exact HTML comparison, part 3

Exact HTML comparison, part 4

Exact HTML comparison, part 5

The preview panels are attached externally to the PR and are intentionally not committed to the repository.

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@mbats
mbats force-pushed the meb/enh/semantic-icon-palette branch 2 times, most recently from 3b85a66 to 3e8a6ef Compare October 13, 2026 12:08
@mbats mbats changed the title [enhancement] Harmonize SysML icons and action diagram node palette [enh] Harmonize SysML icons and action diagram node palette Oct 13, 2026
@mbats
mbats force-pushed the meb/enh/semantic-icon-palette branch from 3e8a6ef to 5cb45a8 Compare October 13, 2026 12:20
@mbats mbats added this to the 2026.11.0 milestone Oct 13, 2026
@mbats mbats self-assigned this Oct 13, 2026
@mbats
mbats requested a review from gcoutable October 13, 2026 13:05
.borderRadius(0)
.borderSize(0)
.background(this.colorProvider.getColor("black"))
.background(this.colorProvider.getColor("actionGreen"))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the color here means that even when the style customization is disabled, fork and join node will be actionGreen.
Is it what we want?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@gcoutable
gcoutable force-pushed the meb/enh/semantic-icon-palette branch from 2dd2600 to 268ab00 Compare October 16, 2026 13:56
Signed-off-by: Mélanie Bats <[email protected]>
Signed-off-by: Guillaume Coutable <[email protected]>
@gcoutable
gcoutable force-pushed the meb/enh/semantic-icon-palette branch from 268ab00 to 615765a Compare October 16, 2026 14:15
@gcoutable
gcoutable merged commit 6ba2ac6 into main Oct 16, 2026
10 checks passed
@gcoutable
gcoutable deleted the meb/enh/semantic-icon-palette branch October 16, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants