Repository navigation
fix(mount): resolve every symlink inside container rootfs - #191
Merged
bleggett merged 1 commit intoOct 23, 2026
Merged
Conversation
azenla
approved these changes
Oct 23, 2026
kaniini
approved these changes
Oct 23, 2026
tycho
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
mask_pathandmake_readonlyresolve every symlink inside the container's rootfs, so a masked or read-only path always points to the container alone.Ex: An image has the absolute symlink
/bin->/usr/bin, and styrolite is asked to mask/bin/ls. Before this, styrolite resolved/usr/binfrom the outer root instead of the container rootfs, so the mask landed on the wrong file and was discarded at pivot, so the container's/bin/lsstayed readable. With this fix, it correctly follows/usr/bininside the container rootfs and masks the container's own/usr/bin/ls.