Repository navigation
fix: LP-1083 upgrade edx-auth-backends to 5.1.1 to keep next across OAuth session cleanup - #16
Merged
djoseph-apphelix merged 1 commit intoNov 10, 2026
Conversation
djoseph-apphelix
force-pushed
the
djoseph/LP-1083-auth-backends-5.1.1
branch
from
November 6, 2026 18:34
59d61bc to
a529aa0
Compare
robrap
reviewed
Nov 6, 2026
| check_migrations: | ||
| name: check migrations | ||
| runs-on: ubuntu-latest | ||
| runs-on: ubuntu-24.04 |
There was a problem hiding this comment.
See https://2u-internal.atlassian.net/wiki/spaces/AT/pages/4332748867/Ubuntu+26.04+upgrade for example tickets and comments.
Member
Author
There was a problem hiding this comment.
Thanks, followed the same pattern as the devstack and edx-platform pins:
- LP-1515 tracks the pin. The CI changes are now in their own PR, chore: LP-1515 pin migrations check to ubuntu-24.04 #17 (all checks green), and this PR is back to the dependency bump only. It depends on chore: LP-1515 pin migrations check to ubuntu-24.04 #17 merging first.
- LP-1516 tracks the unpin. The real fix is to run MySQL as a service container the way edx-platform's migrations workflow does, upstream first since openedx/credentials has the identical job.
- Added LP-1516 to the Ubuntu 26.04 upgrade page.
For the record, Credentials is a third root cause: ubuntu-26.04 has no preinstalled MySQL (the job starts it with /etc/init.d/mysql), and its libxmlsec1 1.3.9 no longer builds the xmlsec 1.3.13 that the job compiled from source, which turned out to be dead since xmlsec is no longer a dependency.
djoseph-apphelix
force-pushed
the
djoseph/LP-1083-auth-backends-5.1.1
branch
from
November 7, 2026 06:10
143b4f6 to
1f801a4
Compare
robrap
approved these changes
Nov 9, 2026
robrap
left a comment
There was a problem hiding this comment.
[inform/possible request] I also created openedx/auth-backends#479.
- We should probably create a PR to update the CHANGELOG for the changes we made, and it probably wouldn't be to hard to just get it up to date. If you do this, just note it on the issue ticket. Since this is docs only, we don't need to get it released or tagged.
…Auth session cleanup edx-auth-backends 4.6.2 logs out any existing session when the OAuth flow starts, which flushes the `next` redirect social-auth stored. Learners who already had a Credentials session were sent to LOGIN_REDIRECT_URL (the staff-only API root) instead of their certificate and got HTTP 403. Fixed upstream in openedx/auth-backends#470, released as 5.1.1. The jump across 5.0.0 only drops Python 3.8 and 3.11 support. Ticket: LP-1083
djoseph-apphelix
force-pushed
the
djoseph/LP-1083-auth-backends-5.1.1
branch
from
November 10, 2026 19:38
1f801a4 to
944a50e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
edx-auth-backendsfrom 4.6.2 to 5.1.1 to fix learners getting HTTP 403 on their program certificate link.Root cause.
EdXOAuth2.start()in 4.6.2 logs out any existing session before starting the OAuth flow. That flush also discards thenextredirect social-auth stored a moment earlier, so learners who already had a live Credentials session finished login with no destination and landed onLOGIN_REDIRECT_URL, the staff-only/api/v2/credentials/. Learners with no Credentials session were unaffected, which is why it looked intermittent.Fix. Upstream openedx/auth-backends#470 carries the stored redirect across the session cleanup. Released as 5.1.1.
Compatibility. The jump across 5.0.0 only drops Python 3.8 and 3.11 support. Django, social-auth-core and social-auth-app-django pins are unchanged;
pip checkis clean.Testing
/login/?next=/credentials/<uuid>/now lands on the certificate instead of the 403. Plain login still goes toLOGIN_REDIRECT_URL; logout still chains through to the LMS.credentials/apps/core,credentials/apps/api/tests/test_authentication.pyandcredentials/apps/recordsgive identical results on 4.6.2 and 5.1.1.Ticket: LP-1083