Repository navigation
Conversation
ale18V
marked this pull request as ready for review
September 23, 2026 21:41
ale18V
force-pushed
the
test/decentralized-webapp-ci
branch
from
September 24, 2026 12:38
52131a5 to
73e9130
Compare
ale18V
added this pull request to stack #1235
September 24, 2026 13:05
ale18V
force-pushed
the
test/decentralized-webapp-ci
branch
from
September 24, 2026 20:31
73e9130 to
194a7c6
Compare
ale18V
force-pushed
the
test/decentralized-webapp-ci
branch
from
October 1, 2026 12:44
eb4194d to
adc7523
Compare
ale18V
force-pushed
the
test/decentralized-webapp-ci
branch
from
October 1, 2026 13:10
adc7523 to
2b8e281
Compare
ale18V
force-pushed
the
test/decentralized-webapp-ci
branch
from
October 2, 2026 12:32
12fd154 to
2da0c4b
Compare
ale18V
force-pushed
the
test/decentralized-webapp-ci
branch
from
October 3, 2026 11:16
2da0c4b to
417732e
Compare
ale18V
force-pushed
the
test/decentralized-webapp-ci
branch
from
October 3, 2026 11:20
417732e to
c399a48
Compare
This was referenced Oct 3, 2026
Co-authored-by: Julien Vignoud <[email protected]>
Co-authored-by: Julien Vignoud <[email protected]>
Co-authored-by: Julien Vignoud <[email protected]>
Co-authored-by: Julien Vignoud <[email protected]>
ale18V
force-pushed
the
test/decentralized-webapp-ci
branch
from
October 5, 2026 14:31
c399a48 to
d38c904
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
This PR adds a decentralized webapp end-to-end test for the default MNIST task. A Chrome browser trains with two Node participants over real WebRTC connections. The test also exposed a DiscoJS race that could label outgoing weights with the next aggregation round and leave peers waiting indefinitely; this PR fixes that race. Browser-to-browser coverage is tracked in the stacked #1239.
Technical plan
A dedicated Cypress job starts one MNIST-only test server process with two Node peers, then runs the ordinary Cypress configuration against the webapp. The peers train concurrently with the browser and close when training finishes; the test checks the browser's participant count, epochs, model-sharing rounds, successful completion, and absence of error toasts. DiscoJS captures the aggregation round once for each payload exchange so concurrent arrivals cannot change outgoing message labels.
Deviations from plan
The test uses the existing 24-image CIFAR fixture rather than MNIST samples. It validates image preprocessing, browser-to-Node WebRTC, and model sharing, rather than classification quality or multiclass MNIST accuracy. The CI run also revealed the aggregation-round race, which is fixed here because it prevented reliable completion. The initial harness and separate Cypress config were removed in favor of a simple test-server process, following the review feedback.
Todo
Browser-to-browser Chrome–Firefox coverage is in the stacked #1239.