Repository navigation
feat: check attestation stats per validator name pattern - #238
Open
barnabasbusa wants to merge 1 commit into
Open
barnabasbusa wants to merge 1 commit into
barnabasbusa wants to merge 1 commit into
Conversation
barnabasbusa
force-pushed
the
bbusa/attestation-stats-validator-pattern
branch
from
October 13, 2026 10:57
3f71c32 to
db31609
Compare
barnabasbusa
force-pushed
the
bbusa/attestation-stats-validator-pattern
branch
from
October 13, 2026 11:14
db31609 to
71d2856
Compare
barnabasbusa
changed the base branch from
bbusa/pin-staticcheck
to
bbusa/go-1.26
October 13, 2026 11:14
barnabasbusa
force-pushed
the
bbusa/go-1.26
branch
from
October 13, 2026 11:16
522936b to
5b20c1d
Compare
barnabasbusa
force-pushed
the
bbusa/attestation-stats-validator-pattern
branch
from
October 13, 2026 11:16
71d2856 to
5db2912
Compare
There was a problem hiding this comment.
Adds a validatorNamePattern regex to check_consensus_attestation_stats that scopes both the active-balance denominator and the counted attestation votes to matching validators, plus human-readable per-threshold failure reasons. The filtering is applied carefully (duties keep all validators with a matches flag so Electra aggregation-bit offsets remain aligned), is backwards compatible when no pattern is set, and guards the previous 0/0 division. I found no real defects.
Reviewed 5 changed file(s) @ 5db2912f — no blocking issues found.
"Hope is not a strategy." — Google SRE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_consensus_attestation_statsonly had network-wide thresholds, so a client pair whose validators stopped voting hid under the overall percentage when the other pairs carried participation, which is exactly what client interop runs need to catch. This addsvalidatorNamePatternto restrict the duties and votes to matching validators (same idea as incheck_consensus_block_proposals), so arun_task_matrixovervalidatorPairNameschecks every pair against its own target and head thresholds, and makes the progress and failure messages say which threshold missed, e.g.epoch 14 failed: target votes 94.00% < 98%, instead of a bare "check failed". Verified on a local Lodestar/Prysm crossed devnet.Examples
Check every client pair against its own thresholds:
Only the validators of one pair:
Progress and failure messages now name the missed threshold: