Repository navigation
feat: report the last task status when a task times out - #239
Open
barnabasbusa wants to merge 1 commit into
Open
barnabasbusa wants to merge 1 commit into
barnabasbusa wants to merge 1 commit into
Conversation
barnabasbusa
force-pushed
the
bbusa/timeout-last-status
branch
from
October 13, 2026 10:57
c0ce7d5 to
ba7f2aa
Compare
barnabasbusa
force-pushed
the
bbusa/timeout-last-status
branch
from
October 13, 2026 11:14
ba7f2aa to
ef8fcf7
Compare
barnabasbusa
changed the base branch from
bbusa/pin-staticcheck
to
bbusa/go-1.26
October 13, 2026 11:14
barnabasbusa
force-pushed
the
bbusa/go-1.26
branch
from
October 13, 2026 11:16
522936b to
5b20c1d
Compare
barnabasbusa
force-pushed
the
bbusa/timeout-last-status
branch
from
October 13, 2026 11:16
ef8fcf7 to
7d83089
Compare
There was a problem hiding this comment.
This change wraps task execution errors with a timeoutError helper that appends the task's last progress message when the task's own timer fired or the error wraps context.DeadlineExceeded, adds a lock-protected GetProgressMessage accessor, and makes the finality and sync-status checks report their failure conditions and unsynced clients. I traced every return path and lock interaction and found the logic, locking and error semantics consistent; the new unit test matches the helper's branches.
Reviewed 5 changed file(s) @ 7d830895 — no blocking issues found.
"RTFM."
qu0b
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a check task runs out of time, by its own timeout or its parent's deadline, the only result was
context deadline exceeded, so a failed run had to be dug out of the task logs to learn what never passed. This appends the task's last progress message to the timeout error (task timed out: context deadline exceeded, last status: Waiting for finality, finalized epoch 3 < 1000 (current epoch 5)) for every task, and makescheck_consensus_finalityreport the condition that failed andcheck_consensus_sync_statusname the clients that are not synced. Verified on a local devnet.Examples
A check that never passes inside its timeout (from a local devnet run):
The same applies when the parent's deadline cancels the task, e.g. a check inside
run_tasks_concurrentwith atimeout:check_consensus_finalitywithfailOnCheckMiss: