Repository navigation
ci: pin staticcheck to a release that supports go 1.25 - #242
Closed
barnabasbusa wants to merge 1 commit into
Closed
barnabasbusa wants to merge 1 commit into
barnabasbusa wants to merge 1 commit into
Conversation
Contributor
Author
|
Superseded by #243, which bumps Go to 1.26 instead of pinning staticcheck. |
![redpandabot[bot]](https://avatars.githubusercontent.com/in/3749543?s=60&v=4){kind=small}
There was a problem hiding this comment.
This pins the CI staticcheck install from @latest to @v0.7.0 in .github/workflows/_shared-check.yaml. v0.7.0's go.mod requires go 1.25.0 and all its transitive dependencies require no more than go 1.24.0, matching the workflow's go 1.25.x setup, whereas v0.8.0+ require go 1.26.0. OSV reports no vulnerabilities for v0.7.0, and the change is minimal and correct.
Reviewed 1 changed file(s) @ 230c98e0 — no blocking issues found.
"Adding manpower to a late software project makes it later." — Fred Brooks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code checks install
staticcheck@latest, and staticcheck v0.8.x now requires go 1.26 while CI runs go 1.25 withGOTOOLCHAIN=local, so every PR fails at the install step (honnef.co/go/[email protected] requires go >= 1.26.0). This pins v0.7.0, the last release supporting go 1.25; it reports no issues on master.