Repository navigation
ci: set release-please target-branch to the current branch - #165
Merged
Merged
Conversation
antoninguyot
force-pushed
the
ci/release-please-target-branch
branch
from
November 12, 2026 10:36
0e459d2 to
b626d34
Compare
Without it, release-please targets the default branch (master) when run from legacy/stream-2.1, which opened master release PR #164 from a stale Chart.yaml. Co-Authored-By: Claude Opus 5.5 <[email protected]>
antoninguyot
force-pushed
the
ci/release-please-target-branch
branch
from
November 12, 2026 10:38
b626d34 to
4bfe2c6
Compare
labynocle
approved these changes
Nov 12, 2026
labynocle
left a comment
labynocle
left a comment
There was a problem hiding this comment.
👍 with my current understanding of release-please ^^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
target-branch: ${{ github.ref_name }}on the release-please step, as horizon-helm already does.On master it resolves to
master, so nothing changes here. Legacy branches created from master by the freeze process will now inherit it.legacy/stream-2.1was frozen without it, so its release-please run targeted master and opened #164 from a stale Chart.yaml (appVersionreverted to 2.1.13). The same line is already pushed onlegacy/stream-2.1(90eec4d).Uses a
ci:type so it does not change the pending release PR.🤖 Generated with Claude Code