Skip to content

restore version policy intention to BinaryCompatible after first Scala 3 release - #7

Merged
mr-git merged 2 commits into
masterfrom
m/after-0.1.3
Nov 3, 2026
Merged

mr-git merged 2 commits into
masterfrom
m/after-0.1.3

Conversation

@mr-git

@mr-git mr-git commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Build & Compatibility
    • Binary compatibility checks now use the same policy across all Scala versions.
    • Builds no longer apply a compatibility exemption to Scala versions other than 2.13.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The build now sets versionPolicyIntention to Compatibility.BinaryCompatible without checking the Scala binary version.

Changes: Compatibility policy

Layer / File(s) Summary
Unify binary compatibility policy
build.sbt
versionPolicyIntention no longer branches on scalaBinaryVersion. It now uses Compatibility.BinaryCompatible unconditionally.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: scala-steward

Merge Risk: Minimal · up to 2263a

The change restores binary compatibility checks across both supported Scala versions. No actionable defect is established; merge after normal build checks pass.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: restoring version policy intention to BinaryCompatible after the first Scala 3 release.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d40bf25e-984f-4fa2-ab99-8c40a54e99ad
Commits

Reviewing files that changed from the base of the PR and between 756e0dc and 2263ae6.

Files selected for processing: 1
  • build.sbt

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@mr-git mr-git changed the title [AFTER 0.1.3] restore version policy intention to BinaryCompatible after first Scala 3 release restore version policy intention to BinaryCompatible after first Scala 3 release Nov 3, 2026
@mr-git
mr-git merged commit e843683 into master Nov 3, 2026
13 checks passed
@mr-git
mr-git deleted the m/after-0.1.3 branch November 3, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant