Skip to content

refactor: replace []byte(fmt.Sprintf) with fmt.Appendf #3468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gophersg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: replace []byte(fmt.Sprintf) with fmt.Appendf #3468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/sequencers/single/queue_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ func createTestBatch(t *testing.T, txCount int) coresequencer.Batch {
txs := make([][]byte, txCount)
for i := range txCount {
n := testBatchNonce.Add(1)
txs[i] = []byte(fmt.Sprintf("tx-%d-%d", n, i))
txs[i] = fmt.Appendf(nil, "tx-%d-%d", n, i)
}
return coresequencer.Batch{Transactions: txs}
}
Expand Down Expand Up @@ -745,7 +745,7 @@ func TestBatchQueue_Drain_RollbackBulkPrependAfterCompact(t *testing.T) {
// are in flight, forcing the bulk-prepend rollback path on next drain
const n = 150
for i := range n {
tx := []byte(fmt.Sprintf("tx-%03d", i))
tx := fmt.Appendf(nil, "tx-%03d", i)
require.NoError(t, queue.AddBatch(ctx, coresequencer.Batch{Transactions: [][]byte{tx}}))
}

Expand All @@ -762,7 +762,7 @@ func TestBatchQueue_Drain_RollbackBulkPrependAfterCompact(t *testing.T) {
require.NoError(t, err)
require.Len(t, batch2.Transactions, n+1)
for i := range n {
assert.Equal(t, []byte(fmt.Sprintf("tx-%03d", i)), batch2.Transactions[i])
assert.Equal(t, fmt.Appendf(nil, "tx-%03d", i), batch2.Transactions[i])
}
assert.Equal(t, []byte("tx-new"), batch2.Transactions[n])
}
Expand Down Expand Up @@ -876,7 +876,7 @@ func TestBatchQueue_InFlight_CountsTowardQueueLimit(t *testing.T) {
// fill to capacity
for i := range maxSize {
require.NoError(t, queue.AddBatch(ctx, coresequencer.Batch{
Transactions: [][]byte{[]byte(fmt.Sprintf("tx%d", i))},
Transactions: [][]byte{fmt.Appendf(nil, "tx%d", i)},
}))
}

Expand Down
Loading