#75: Implemented socket abstraction library by sgn4sangar · Pull Request #77 · exasol/udf-runner-cpp

sgn4sangar · 2026-09-30T07:16:45Z

fixes #75

tomuben · 2026-10-07T11:08:30Z

+    ASSERT_EQ(::close(second_pipe[1]), 0);
+}
+
+TEST(SocketTest, ListenerConnectsAcceptsAndRequiresExplicitCleanup)


Maybe move all tests which use the unique_socket_path into a GTest fixture, which provides the temp path, and then automatically cleans up the temporary directory in TearDown().

You can also use the same class I created in the DB, see
https://github.com/exasol/db/blob/tu.master.SPOT-31038_refactor_udf_fw/Engine/src/exscript/pluggable/server_based/test_utils/temporary_directory_cleanup.h and https://github.com/exasol/db/blob/tu.master.SPOT-31038_refactor_udf_fw/Engine/src/exscript/pluggable/server_based/test_utils/temporary_directory_cleanup.cpp

and here is an example of usage:
https://github.com/exasol/db/blob/e3887e7a372074faada36afe74e1a7f3672899f6/Engine/src/exscript/pluggable/server_based/instance/connection/unix_domain_socket_transport_utest.cpp#L35

In db reference, there is a dedicated RAII cleanup class; the v2 fixture currently performs the cleanup directly in TearDown(), which, i guess matches the requested behavior. pls correct me if i am wrong

kratz00 · 2026-10-07T14:14:21Z

+
+UnixSocketListener::~UnixSocketListener()
+{
+    close();


I feel like the design does not follow RAII principles, we should also add the "unlink" to the destructor,
this would also thin out the public API

@tkilias should we go for it? i remember you saying the unix-sock-fd migrate between processes.

kratz00 · 2026-10-07T14:15:16Z

+    }
+    if (::listen(socket_fd.native_handle(), backlog) == -1)
+    {
+        throw std::system_error(errno, std::generic_category(), "listen on Unix socket");


bind created the path, listen fails, how do you unlink the path then?

UnixSocketListener::bind being a static function; if listen fails, i mean throws exception, is it not the caller's responsibility to unlink it.

sonarqubecloud · 2026-10-12T08:22:07Z

Quality Gate failed

Failed conditions
65.2% Coverage on New Code (required ≥ 80%)
D Security Rating on New Code (required ≥ A)
3 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

tkilias · 2026-10-13T11:52:25Z

+    return std::exchange(this->file_descriptor, -1);
+}
+
+OwnedFileDescriptor::OwnedFileDescriptor(const int owned_fd) noexcept : file_descriptor(owned_fd)


OwnedFileDescriptor impl should go into its own cc file

tkilias · 2026-10-13T11:53:29Z

+
+using exasol::udf::v2::socket::OwnedFileDescriptor;
+
+TEST(SocketTest, OwnedDescriptorClosesExactlyOnceAfterMoveAndRelease)


rename file to the class that is actually tested here OwnedFileDescriptor

sgn4sangar requested a deployment to v2-fuzzing-pr-approval September 30, 2026 07:16 — with GitHub Actions Waiting

tomuben reviewed Sep 30, 2026

View reviewed changes

Comment thread udf-runner-cpp/v2/include/exasol/udf/v2/socket/socket.hpp Outdated

sgn4sangar added 8 commits October 3, 2026 13:07

#75: Add socket library API stubs

7a7177f

#75: Implement socket descriptor ownership

5f0b5d1

#75: Implement Unix socket connection and listener

871c26a

#75: Implement Unix socket stream operations

2634830

#75: Add Unix socket tests and fuzzing

5648402

#75: Group socket library files

c3bdcd3

#75: Fix socket clang-tidy findings

6ce6314

#75: Extend socket mutation coverage

f4ee0d7

sgn4sangar force-pushed the feature/75_implement_socket_abstraction_library branch from 7d4b2d4 to f4ee0d7 Compare October 3, 2026 07:42

sgn4sangar requested a deployment to v2-fuzzing-pr-approval October 3, 2026 07:42 — with GitHub Actions Waiting

sgn4sangar added 2 commits October 3, 2026 14:04

#75: Rename the development Lima template

c24a3cc

#75: Exclude socket tests from Mull

2590e45

sgn4sangar requested a deployment to v2-fuzzing-pr-approval October 5, 2026 09:27 — with GitHub Actions Waiting

#75: Address socket Sonar findings

cc4654e

sgn4sangar requested a deployment to v2-fuzzing-pr-approval October 5, 2026 11:39 — with GitHub Actions Waiting

#75: Format socket Sonar suppression

4873bc7

sgn4sangar requested a deployment to v2-fuzzing-pr-approval October 5, 2026 12:19 — with GitHub Actions Waiting

#75: Resolve remaining socket Sonar findings

25b581c

sgn4sangar requested a deployment to v2-fuzzing-pr-approval October 5, 2026 14:22 — with GitHub Actions Waiting

sgn4sangar added 2 commits October 5, 2026 19:57

#75: Move socket sources out of public headers

f4f46c8

#75: Group socket sources in a module folder

faa6427

sgn4sangar requested a deployment to v2-fuzzing-pr-approval October 6, 2026 05:00 — with GitHub Actions Waiting

sgn4sangar added 3 commits October 7, 2026 11:23

#75: Use short secure socket test paths

789c365

#75: Keep socket corpus changes untracked

9496da5

add more corpus files for test

706a115

sgn4sangar requested a deployment to v2-fuzzing-pr-approval October 7, 2026 06:11 — with GitHub Actions Waiting