Conversation
kaptinlin
marked this pull request as ready for review
October 3, 2026 17:07
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numeric comparisons currently convert integer operands to
int, souint64(math.MaxUint64) > uint64(0)evaluates to false anduint64(math.MaxUint64) == int64(-1)evaluates to true. Converting integers tofloat64also makes distinct values beyond 2^53 compare equal.Preserve signedness and width in the comparison generator. Mixed integer/float comparisons check the integer range and compare the integral part before the fractional part, preserving IEEE NaN ordering. Regenerate the five comparison helpers and add public
Compile/Runregressions for typed and dynamic environments.Validation on Go 1.27:
go test -p 1 ./...go test -race -p 1 .go test -p 1 -tags=expr_debug -run=TestDebugger ./vmgo vet ./...go test -p 1 -ldflags='-s -w' -run '^$' -fuzz '^FuzzNumericComparison$' -fuzztime=20s -parallel=1 .passed 392,471 inputs against amath/big.Ratoracle.A temporary go-valueexpr workspace also reproduces the corrected comparisons while preserving uint64 identity and its existing Shape type checks. Arithmetic helpers are byte-identical to the base.