Repository navigation
Diff Checker: wheel scrolling, share links, release the new engine - #9
Merged
Merged
Conversation
.cm-mergeView is the one scroller for both panes. Fixed heights inside it kept it from ever overflowing, so the content was clipped by the package's overflow:hidden editor wrapper: the wheel did nothing and only the cursor could move it. Use min-height instead.
CodeMirror's built-in diff gave up on this pair and marked every line changed, including the identical networking block. The two-stage engine gets it right; keep it that way.
Both sides are deflated into the URL fragment, which browsers never send to a server, so there is still no backend. Links are capped at 8 KB encoded, and decoding stops at 2 MB so a crafted link cannot inflate without bound. The link is encoded ahead of the click, since Safari refuses clipboard writes after an await. Opening one replaces the saved diff, says so, and strips the fragment.
#8 added its entries under [0.4.0], which had already been released, so the release workflow found nothing to ship and the new engine never deployed. Also record the scroll fix, the highlighting fix and share links.
fadeltd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Fixed
[Unreleased], so the new diff engine releases