Repository navigation
Preserve TCP ECN flags when parsing and serializing packets - #214
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
Decoding a TCP header drops ECE and CWR, so a packet round trip loses its ECN flags. Serializing the existing TCP_NS constant raises struct.error.
Preserve all nine exposed flag bits across both header bytes, including automatic data offset calculation. The reserved bits stay ignored.
Four regressions cover all 512 flag combinations, automatic and explicit offsets, options padding, checksums and IPv4/IPv6 packet round trips. All four fail before the fix. On Python 3.9.25,
python ryu/tests/run_tests.py ryu.tests.unit.packetpasses all 794 tests.python ryu/tests/run_tests.pyreports 121,915 tests, one skip and zero failures with the declared minimum ovs 2.6.0.python setup.py sdist bdist_wheelpasses in an isolated source copy. The manager startup check passes.pycodestyle ryuandautopep8 --recursive --diff ryu/pass with pycodestyle 2.7.0 and autopep8 1.5.7.Current pycodestyle 2.14.0 reports the same 50 existing source findings on this branch and upstream. With ovs 3.7.1, both full suites have 15 OVS errors and two resulting failures. Those errors use the removed ovs.db.idl._uuid_to_row helper.