Repository navigation
chore(verify): pin the reference apps to the adapter releases with the guard fixes - #253
Merged
Merged
Conversation
…e guard fixes Under 0.x a caret range locks the minor, so the released smoke run kept installing express 0.19 and fastify 0.10, which still carry the bugs the adapter specs check for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the reference apps to
@seamless-auth/express ^0.20.0and@seamless-auth/fastify ^0.11.0. Under 0.x a caret locks the minor, so the daily released smoke test kept installing 0.19 and 0.10, which still have the token-in-body, Fastify cookie-guard and session-cookie-kind bugs the adapter specs check for. With these pins it tests the releases that fix them.