Repository navigation
fix(init): scaffold auth server v0.18.0 and print each api starter's own command - #254
Merged
Merged
Conversation
…own command The Go, Rust and Python adapters and @seamless-auth/client send the OTP and magic-link send routes as POST, which v0.17.0 answers with 404. v0.18.0 serves both, so the Express and Fastify starters are unaffected. The next steps no longer tell a Gin, Axum or FastAPI project to run npm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes the Go, Rust and Python api starters need (fells-code/seamless-templates#113, under fells-code/seamless-auth-api#371).
Auth server pin: v0.17.0 to v0.18.0. In v0.17.0 the OTP and magic-link send routes (
/otp/generate-email-otpand friends) areGET. From v0.18.0 they arePOST, with theGETs kept but deprecated, because a GET that sends a message can be triggered cross-site. The Go, Rust and Python adapters follow the v0.18 manifest, and the current@seamless-auth/clientalso sendsPOST, so a project scaffolded on the v0.17.0 pin fails at "send code" with 404. I hit this scaffolding the new starters. v0.18.0 still serves theGETroutes, so the Express and Fastify starters keep working. The v0.18.0 image is published on ghcr.Next steps per api starter. After
seamless init, the next steps told every api starter tocd api && npm install && npm run dev. They now come fromapiDevCommand(framework):go run .(Gin)cargo run(Axum)uv run uvicorn app.main:build --factory --reload --port 3000(FastAPI)These match each starter's README. Gin and Axum also get display names.
I checked all three new starters end to end against a scaffold whose auth image was set to v0.18.0. The templates pin (
SEAMLESS_TEMPLATES_REF) is left alone: it moves when seamless-templates releases #113.tsc --noEmit,check:types-current,check:templates-pin,buildand the full test suite (1177 passed) all pass.