Repository navigation
feat(verify): run the browser specs against an Angular app - #256
Merged
Merged
Conversation
5 tasks
The browser projects are pinned to 127.0.0.1 with --host-resolver-rules, but global setup checked http://localhost:5173/health from Node, which resolves localhost to ::1 first. A dev server left running on [::1]:5173 answered the check while the container under test was still starting, and the first spec then failed with a connection reset.
Adds angular and angular-dev layers that drive an app on @seamless-auth/angular through the same specs as the React template; its screens keep the same accessible names. The reference app in verify/angular-app runs until an Angular web template exists (seamless-templates#111), a web template whose framework or verify.project is angular is routed to the same runtime, and SEAMLESS_ANGULAR_DIR points the run at another app. With --local the client and the built Angular package are packed into verify/angular-vendor. Refs fells-code/seamless-auth-react#170, #246.
Bccorb
marked this pull request as ready for review
October 9, 2026 00:36
Bccorb
force-pushed
the
feat/verify-angular
branch
from
October 9, 2026 00:36
40c9369 to
8eb2380
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs the browser conformance specs against an Angular app, for fells-code/seamless-auth-react#170 (the browser project item) under fells-code/seamless-auth-api#371.
What changes
New layers.
angularandangular-devPlaywright projects point at the existing./reactspecs, with no copy of the suite.@seamless-auth/angularkeeps the React screens' accessible names, so the register, email OTP, magic link, passkey register and login, OAuth and logout specs run unchanged.Reference app in
verify/angular-app:@seamless-auth/angular, with its own Dockerfile. Theruntimetarget is nginx with/healthand a runtimeconfig.js. Thedevtarget isng serve.angularandangular-dev, with CI cache scopes.Routing in the verify command:
verify.projectorframeworkisangularuses the new runtime. This is ready for seamless-templates#111.SEAMLESS_ANGULAR_DIRpoints the run at another Angular app.--localpacks@seamless-auth/clientand the built@seamless-auth/angular(frompackages/angular/dist, which is what npm publishes) intoverify/angular-vendor.The matrix reporter knows the new layers, and the summary lists the Angular version.
fix(verify), a separate commit. Global setup checked the web app's/healthonlocalhost. Node resolves that to::1first, while the browser is pinned to127.0.0.1. A dev server left running on[::1]:5173therefore answered the check while the container under test was still starting, and the first spec failed withERR_CONNECTION_RESET. The check now uses the address the browser uses.Checks (real output)
node dist/index.js verify --local --devwas run with:All 9 layers passed:
Merge order
This is a draft until fells-code/seamless-auth-react#173 is merged and
@seamless-auth/angularis published.