Repository navigation
fix: ft pg-lift --bam passes the output BAM positionally to pg-pansn - #153
Open
mtcicero26 wants to merge 1 commit into
Open
mtcicero26 wants to merge 1 commit into
mtcicero26 wants to merge 1 commit into
Conversation
pg-pansn takes its output BAM as a positional argument, but pg-lift's final BAM stage passed --out, so every BAM-mode lift stopped with "unexpected argument '--out'". The ft stage arguments are now built by first_stage_args/final_stage_args, and a unit test parses every stage with ft's own CLI. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ft pg-lift --bamfails on every input: the final stage runsft pg-pansn - --strip --out <OUT> …, butpg-pansntakes its output BAM positionally, so clap stops withunexpected argument '--out' found. BED mode is unaffected (pg-injectdoes take--out).ftstage arguments are built byfirst_stage_args/final_stage_argsinstead of inline vectors.pipeline_stage_args_parseparses every stage (BAM and BED mode) with ft's ownCli. It fails on the old arguments with the original error and passes with the fix.Tested end to end with vg 1.77.0 on a small Minigraph-Cactus graph (GRCh38 + HG002 Q100 maternal/paternal), lifting FiberHMM-called Fiber-seq and scDAF-seq BAMs from HG002 to GRCh38. Other things we saw after
vg inject | vg surject(supplementary flags, stale MD/NM,ston strand flips, BED12 blocks) are in a separate issue.🤖 Generated with Claude Code