Repository navigation
fix: correctly set MA read length when making fibertig - #156
Merged
Merged
Conversation
Member
|
Was this issue new with the MA introduction? |
Contributor
Author
sort of. the alignment record was the right (window size) length, but with addition of MA tag, the read_length part of ma tag was being filled with total contig length, so an oversight. |
BAM packs each CIGAR operation length into 28 bits. ft mock-fire and
pg-inject wrote one = (and H) op per record, so a span over 268,435,455 bp
wrapped silently and htslib could not read the record back ("CIGAR and
query sequence lengths differ"). Split long ops into several of the same
kind. union-peaks no longer needs its island length guard.
Fixes #155
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ft pg-inject splits a contig into windows, but built each window's annotations with the full contig length, not its window size. this corrects that.