Repository navigation
INTER-2697: chore: bump next to 16.4.2 in Next.js examples - #214
Merged
Merged
Conversation
Fixes GHSA-2464-fhr4-w9xw and GHSA-673q-mjm6-r5xr (remote code execution in next 16.0.0 - 16.4.0), patched in 16.4.1: GHSA-2464-fhr4-w9xw Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01FPBJ9DRFq4u6eoLci23B6S
Contributor
Coverage report
Test suite run success43 tests passing in 15 suites. Report generated by 🧪jest coverage report action from 6a0da9c Show full coverage report
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Both dependency-pin changes match the lockfile and compatibility requirements, with no unresolved findings.
No open issues 🎉
What changed in this PR
Updates the Next.js examples to address the security advisories cited in the PR, without changing the published @fingerprint/react package.
Changes:
- Bumps
nextfrom16.2.10to16.4.2in both example apps. - Keeps both examples on the same pinned Next.js version.
| File | Description |
|---|---|
examples/next/package.json |
Updates the Pages Router example’s Next.js dependency. |
examples/next-appDir/package.json |
Updates the App Router example’s Next.js dependency. |
Review effort: Balanced
3 tasks done
JuroUhlar
pushed a commit
that referenced
this pull request
Oct 26, 2026
First PR as a part of [INTER-2456](https://fingerprintjs.atlassian.net/browse/INTER-2456). We're looking to standardize usage of `tags` across SDKs. We will ensure that `tag` keeps working, and `tags` wins if both are passed. The lockfile change is pretty large, but the only change from this PR is `@fingerprint/agent` 4.1.2 → 4.1.6. The rest is explained in the PR description in #214. Whichever of the two merges second will need to regenerate the lockfile. Changes: - Require `@fingerprint/agent` 4.1.6 or later so `tags` is in `GetOptions` - Add `tags` to the options cache key. Without it, changing `tags` didn't trigger a new request and calls with different `tags` were deduplicated - Update the README and `create-react-app` example to use `tags`, with a note that `tag` is deprecated Testing: - [x] Added tests for the cache key fix. Changing `tags` triggers a new request, and calls with different `tags` aren't deduplicated. Both failed before the fix - [x] Existing `tag` tests still pass - [x] Built the `create-react-app`, `next` and `next-appDir` examples locally [INTER-2456]: https://fingerprintjs.atlassian.net/browse/INTER-2456?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Resolve the pnpm-lock.yaml conflict by taking main's lockfile and re-running `pnpm install --lockfile-only` with the next 16.4.2 bump. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Ek3ikuFksHMLfvT9RxEovT
Next 16.4 adds a root-params type import; without it every local build dirties the tree. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Ek3ikuFksHMLfvT9RxEovT
Contributor
🚀 Following releases will be created using changesets from this PR:@fingerprint/[email protected]Minor Changes
Patch Changes
|
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
No concrete defects were identified, but the React 18/19 end-to-end CI results remain unverified for this framework and native-dependency upgrade.
No open issues 🎉
1 file not reviewed
pnpm-lock.yaml: Generated file
Review effort: Balanced
JuroUhlar
marked this pull request as ready for review
October 26, 2026 14:54
JuroUhlar
requested review from
TheUnderScorer,
ilfa and
mcnulty-fp
as code owners
October 26, 2026 14:54
mcnulty-fp
approved these changes
Oct 26, 2026
TheUnderScorer
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of INTER-2697.
Context
GHSA-2464-fhr4-w9xw | GHSA-673q-mjm6-r5xr
Why
The Next.js example apps pin
[email protected], which has 2 critical remote code execution advisories fixed in 16.4.1.Things to note
@fingerprint/reactpackage doesn't depend onnext, so there's no changeset and no release.nextand its own sub-dependencies (@next/*,sharp,@img/*,@swc/helpers,postcss,@emnapi/runtime).next-env.d.tsin both examples is regenerated by Next 16.4, which adds aroot-params.d.tsimport.Verification
Locally, after building the SDK: both examples build on
next16.4.2 with React 18 (with a placeholderNEXT_PUBLIC_FPJS_PUBLIC_API_KEY), andtypecheckandlintpass in both. The e2e matrix, including React 19, runs in CI only.Change outline
nextfromnexttoexamples/nextexamples/next-appDirGenerated by Claude Code