Skip to content

INTER-2697: chore: bump next to 16.4.2 in Next.js examples - #214

Merged
JuroUhlar merged 3 commits into
mainfrom
fix/next-examples-ghsa-2464
Oct 26, 2026
Merged

JuroUhlar merged 3 commits into
mainfrom
fix/next-examples-ghsa-2464

Conversation

@JuroUhlar

@JuroUhlar JuroUhlar commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Part of INTER-2697.

Context

GHSA-2464-fhr4-w9xw | GHSA-673q-mjm6-r5xr

Why

The Next.js example apps pin [email protected], which has 2 critical remote code execution advisories fixed in 16.4.1.

Things to note

  • Examples only. The published @fingerprint/react package doesn't depend on next, so there's no changeset and no release.
  • The lockfile diff only touches next and its own sub-dependencies (@next/*, sharp, @img/*, @swc/helpers, postcss, @emnapi/runtime).
  • next-env.d.ts in both examples is regenerated by Next 16.4, which adds a root-params.d.ts import.

Verification

Locally, after building the SDK: both examples build on next 16.4.2 with React 18 (with a placeholder NEXT_PUBLIC_FPJS_PUBLIC_API_KEY), and typecheck and lint pass in both. The e2e matrix, including React 19, runs in CI only.

Change outline

Example next from next to
examples/next 16.2.10 16.4.2
examples/next-appDir 16.2.10 16.4.2

Generated by Claude Code

Fixes GHSA-2464-fhr4-w9xw and GHSA-673q-mjm6-r5xr (remote code
execution in next 16.0.0 - 16.4.0), patched in 16.4.1:
GHSA-2464-fhr4-w9xw

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01FPBJ9DRFq4u6eoLci23B6S
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Coverage report

St.❔
Category Percentage Covered / Total
🟢 Statements 96.79% 151/156
🟢 Branches 95.51% 85/89
🟢 Functions 97.78% 44/45
🟢 Lines 97.33% 146/150

Test suite run success

43 tests passing in 15 suites.

Report generated by 🧪jest coverage report action from 6a0da9c

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🟢 All files 96.79 95.5 97.77 97.33
🟢  src 100 100 100 100
🟢   detect-env.ts 100 100 100 100
🟢   env.types.ts 100 100 100 100
🟢   ...nt-context.ts 100 100 100 100
🟢   ssr.ts 100 100 100 100
🟢   ...sitor-data.ts 100 100 100 100
🟢  src/components 100 100 100 100
🟢   ...-provider.tsx 100 100 100 100
🟢   ...vironment.tsx 100 100 100 100
🟢  src/utils 88.09 87.5 92.3 90
🟢   ...is-defined.ts 100 100 100 100
🟢   ...-cache-key.ts 80.76 83.33 85.71 84 5,10,43,52
🟢   to-error.ts 100 100 100 100
🟢   ...mise-store.ts 100 100 100 100

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Both dependency-pin changes match the lockfile and compatibility requirements, with no unresolved findings.

No open issues 🎉

What changed in this PR

Updates the Next.js examples to address the security advisories cited in the PR, without changing the published @fingerprint/react package.

Changes:

  • Bumps next from 16.2.10 to 16.4.2 in both example apps.
  • Keeps both examples on the same pinned Next.js version.
File Description
examples/​next/​package.json Updates the Pages Router example’s Next.js dependency.
examples/​next-appDir/​package.json Updates the App Router example’s Next.js dependency.

Review effort: Balanced

@JuroUhlar JuroUhlar changed the title chore: bump next to 16.4.2 in Next.js examples INTER-2697: chore: bump next to 16.4.2 in Next.js examples Oct 23, 2026
JuroUhlar pushed a commit that referenced this pull request Oct 26, 2026
First PR as a part of
[INTER-2456](https://fingerprintjs.atlassian.net/browse/INTER-2456).
We're looking to standardize usage of `tags` across SDKs. We will ensure
that `tag` keeps working, and `tags` wins if both are passed.

The lockfile change is pretty large, but the only change from this PR is
`@fingerprint/agent` 4.1.2 → 4.1.6. The rest is explained in the PR
description in #214. Whichever of the two merges second will need to
regenerate the lockfile.

Changes:
- Require `@fingerprint/agent` 4.1.6 or later so `tags` is in
`GetOptions`
- Add `tags` to the options cache key. Without it, changing `tags`
didn't trigger a new request and calls with different `tags` were
deduplicated
- Update the README and `create-react-app` example to use `tags`, with a
note that `tag` is deprecated

Testing:
- [x] Added tests for the cache key fix. Changing `tags` triggers a new
request, and calls with different `tags` aren't deduplicated. Both
failed before the fix
- [x] Existing `tag` tests still pass
- [x] Built the `create-react-app`, `next` and `next-appDir` examples
locally

[INTER-2456]:
https://fingerprintjs.atlassian.net/browse/INTER-2456?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Resolve the pnpm-lock.yaml conflict by taking main's lockfile and
re-running `pnpm install --lockfile-only` with the next 16.4.2 bump.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01Ek3ikuFksHMLfvT9RxEovT
Next 16.4 adds a root-params type import; without it every local build dirties the tree.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01Ek3ikuFksHMLfvT9RxEovT
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Following releases will be created using changesets from this PR:

@fingerprint/[email protected]

Minor Changes

  • Support tags in useVisitorData and deprecate tag (7e66a5c)

Patch Changes

  • Bump @fingerprint/agent dependency to ^4.1.6 (7e66a5c)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

No concrete defects were identified, but the React 18/19 end-to-end CI results remain unverified for this framework and native-dependency upgrade.

No open issues 🎉

1 file not reviewed
  • pnpm-lock.yaml: Generated file

Review effort: Balanced

@JuroUhlar
JuroUhlar requested a balanced review from Copilot October 26, 2026 14:53
@JuroUhlar
JuroUhlar marked this pull request as ready for review October 26, 2026 14:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Successful React 18/19 CI results remain unconfirmed for the framework, generated types, and native-dependency updates.

No open issues 🎉

1 file not reviewed
  • pnpm-lock.yaml: Generated file

Review effort: Balanced

@JuroUhlar
JuroUhlar merged commit 6c23e6d into main Oct 26, 2026
39 checks passed
@JuroUhlar
JuroUhlar deleted the fix/next-examples-ghsa-2464 branch October 26, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants