Skip to content

[AppCheck] Disable TokenAutoRefresh in tests - #1955

Open
a-maurice wants to merge 1 commit into
mainfrom
am-app_check_test
Open

a-maurice wants to merge 1 commit into
mainfrom
am-app_check_test

Conversation

@a-maurice

Copy link
Copy Markdown
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Prevent the App Check test from auto initializing, since the tests are using timestamps to determine information about the tokens, and the auto-initialization is causing some flakiness.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Info.plist file for the app_check integration test to disable Firebase App Check token auto-refresh by setting FirebaseAppCheckTokenAutoRefreshEnabled to false. There are no review comments, and I have no feedback to provide.

@a-maurice a-maurice added the tests-requested: quick Trigger a quick set of integration tests. label Nov 3, 2026
@github-actions github-actions Bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

✅  Integration test succeeded!

Requested by @a-maurice on commit e4388f0
Last updated: Mon Nov 2 16:40 PST 2026
View integration test log & download artifacts

@github-actions github-actions Bot added the tests: succeeded This PR's integration tests succeeded. label Nov 3, 2026
@firebase-workflow-trigger firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 3, 2026
@a-maurice a-maurice added the skip-release-notes Skip release notes check label Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant