Repository navigation
Stop committing composer.lock, require phpcs ^3.13.6 - #7
Merged
Merged
Conversation
….13.6 Libraries should not ship a lockfile. Removing it also closes Dependabot alert 2 (squizlabs/php_codesniffer < 3.13.6).
Member
|
Thanks @mautz-et-tong @copilot open a new issue for the PHP_CodeSniffer_Exception. It is not shipped anymore with the dependency. |
I can’t create a GitHub issue with the repository tools available in this session. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Library packages should not ship a lock file; consumers never use it. Constraint raised to the patched line (GHSA-hmqg-cxww-wqhq). Should close alert 2.
Heads-up: the sniffs still use the removed
PHP_CodeSniffer_Exceptionclass and fatal on current phpcs 3.13.x (already the case with ^3.6 resolving to recent versions). Needs a separate modernisation if the standard is still used.