Repository navigation
Start new rolling services; add post-deploy hooks - #42
Open
codecollision wants to merge 2 commits into
Open
codecollision wants to merge 2 commits into
codecollision wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes requested by the flowcanon agent after flowcanon.com's 2.2.3 deploy failed (gh run 39691894723).
Start a rolling service that has nothing to roll from
2.2.3 added a
schedulerwith nodeploy.strategy. A rolling deploy scales to 2, which assumes an old container already exists. With none, it started two new containers, failed with "Could not identify old/new containers" and reverted the whole deploy. A rolling service with no running container (new, or stopped) is now pulled, started at 1 and health-checked, as drain-first services already were. If it fails, it is removed and the deploy reverts as usual.deploy.post-deployhookscompose exec -T <svc> sh -c '<cmd>', indeploy.order, after every service is healthy.--serviceruns only the hooks of the services it deploys.$$is unescaped to$.compose configprints a literal$as$$, which real Docker exposed: without the unescape,$$VARran as the shell's PID followed byVAR.Tests
tests/test_new_service.pyandtests/test_post_deploy.py. FakeHost now models compose recreating stopped diverged containers too.Not changed: reverting services that already shipped
In 2.2.3 the backend was rolled back onto a schema that had already been migrated, and it never came healthy. That is the documented expand-then-contract contract, so this PR keeps the revert as it is. With the new-service fix, that deploy wouldn't have failed at all.
🤖 Generated with Claude Code