Skip to content

chore(rig): drop the dead EPISODES queue and its unreachable scenarios (#143) - #161

Merged
terenceponce merged 2 commits into
mainfrom
chore/drop-rig-episodes
Nov 1, 2026
Merged

terenceponce merged 2 commits into
mainfrom
chore/drop-rig-episodes

Conversation

@terenceponce

Copy link
Copy Markdown
Member

Closes #143.

Executes the drop branch of the wire-or-drop fork: the PA's declared default (drop — dead code misleads) stood in the decision card, was not countermanded, and tonight's standing word is continue-working. Reversibility: if the owner rules wire-in-the-morning, git revert of this squash restores everything — the scenarios' text lives in git history, and the wiring rule ADR 0029 originally recorded (pop an episode before taking a stock number) is the design to implement.

What dies (−201/+30 across 3 files)

Evidence

  • Full-menu scenario smoke: 38/41 green — every argparse choice (35) in its primary mode plus secondary gif/probe modes where the rig dispatches both; supersedes the 0125 lane's 26-scenario bar (the menu grew since). The 3 reds — attach (still), attach (gif), drop-image (gif) — are proven pre-existing on main: parent 54d8248's unmodified rig, same worktree, same venv, reproduces the byte-identical pyte 0.8.2/Python 3.14 IndexError (rc=1, two shapes confirmed). Filed as Rig env: pyte 0.8.2 under Python 3.14 crashes rendering the image scenarios (attach, drop-image) — pre-existing on main #160; not this PR's regression — the queue never popped, so nothing could regress; proven anyway.
  • mix ci exit 0 — 1836 passed, coverage 99.2% (floor).
  • Sentinel-site floor untouched: the dead scenarios waited on literals, not stock_closing — 9 sites before and after.
  • CHANGELOG: none — rig-internal deletion, no user delta ([Unreleased] stays fresh; the 0132 precedent).

Review

Hostile review by fresh-context glm-5.3 in its own read-only worktree, same host — DISCLOSED: verdict SHIP, 2 P3 nits (ADR provenance locatability; strikethrough off house style), both fixed in 593209d; delta re-checked by the same reviewer — APPROVE.

Non-visual: rig deletion, no captures to embed.

@terenceponce
terenceponce force-pushed the chore/drop-rig-episodes branch from 593209d to 604af6a Compare November 1, 2026 16:33
@codecov

codecov Bot commented Nov 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@terenceponce
terenceponce merged commit aa62d6f into main Nov 1, 2026
5 checks passed
@terenceponce
terenceponce deleted the chore/drop-rig-episodes branch November 1, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Capture rig: EPISODES never popped — scripted interaction scenarios cannot regenerate

1 participant