Repository navigation
chore(rig): drop the dead EPISODES queue and its unreachable scenarios (#143) - #161
Merged
Merged
Conversation
terenceponce
force-pushed
the
chore/drop-rig-episodes
branch
from
November 1, 2026 16:33
593209d to
604af6a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #143.
Executes the drop branch of the wire-or-drop fork: the PA's declared default (drop — dead code misleads) stood in the decision card, was not countermanded, and tonight's standing word is continue-working. Reversibility: if the owner rules wire-in-the-morning,
git revertof this squash restores everything — the scenarios' text lives in git history, and the wiring rule ADR 0029 originally recorded (pop an episode before taking a stock number) is the design to implement.What dies (−201/+30 across 3 files)
MockHandler.EPISODES+App.script/1— the FIFO nothing ever popped (consumer lost in the Approve prompts become a multiple-choice question in the input field #133–Auto mode must never ask permission: execute or auto-reject #135 era, fix(tui): footer width math shares the transcript renderer's classifier (#139) #142 deleted its unused corpse).VET_REPLY+is_vet_request— zero callers since the feat(tui): approvals and the ask-user tool share one choice widget; auto mode never asks (#133 #134 #135) #141 era; the episode/vet dispatch never landed.scenario_approve_choice/scenario_question_single/scenario_question_multi/scenario_auto_reject(never in the argparse menu), their still+gif dispatch branches, and the shared key-constant line (UP, DOWN, SPACE, ENTER, ESC— no other users).test/dash_float/rig_needle_test.exs(bijection re-verified: every remaining entry has a live needle, every needle an entry).docs/screenshots/133–135/stay untouched as frozen evidence (the widget behavior is app code, ADR 0028, with its own tests).Evidence
attach(still),attach(gif),drop-image(gif) — are proven pre-existing on main: parent54d8248's unmodified rig, same worktree, same venv, reproduces the byte-identical pyte 0.8.2/Python 3.14IndexError(rc=1, two shapes confirmed). Filed as Rig env: pyte 0.8.2 under Python 3.14 crashes rendering the image scenarios (attach, drop-image) — pre-existing on main #160; not this PR's regression — the queue never popped, so nothing could regress; proven anyway.mix ciexit 0 — 1836 passed, coverage 99.2% (floor).stock_closing— 9 sites before and after.Review
Hostile review by fresh-context glm-5.3 in its own read-only worktree, same host — DISCLOSED: verdict SHIP, 2 P3 nits (ADR provenance locatability; strikethrough off house style), both fixed in 593209d; delta re-checked by the same reviewer — APPROVE.
Non-visual: rig deletion, no captures to embed.