Repository navigation
Keep default ignorables that GSUB substituted - #406
Merged
blikblum merged 1 commit intoOct 23, 2026
Merged
Conversation
Member
|
@lehni |
lehni
force-pushed
the
fix/substituted-default-ignorables
branch
from
October 21, 2026 22:06
435b1f0 to
a9b1cae
Compare
Contributor
Author
|
@blikblum rebased |
Member
|
Conflicted again. Lets merging one at time |
- A soft hyphen replaced by its case form was still swapped for an invisible space, as the substituted glyph keeps the soft hyphen's code point - Hide only default ignorables that still show their nominal glyph, as HarfBuzz does - Add tests for hiding a soft hyphen and keeping its case form, with Fira Sans
lehni
force-pushed
the
fix/substituted-default-ignorables
branch
from
October 22, 2026 23:29
a9b1cae to
b620cb3
Compare
Contributor
Author
|
@blikblum Rebased onto master. The conflicts come from all the PRs adding their tests at the end of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observed with real fonts: Fira Sans (already in the test data) and our Akkurat family ship a
caseform of the soft hyphen (uni00AD.case). HarfBuzz shows it in"AB"withcaseon; fontkit swaps it for an invisible space.hb-shape --features=case FiraSans-Regular.ttf "AB"givesA uni00AD.case B)