Repository navigation
Resolve mark attachments after zeroing mark advances - #407
Merged
Merged
Conversation
- Attached marks were offset by the advances of the marks between them and their base, which shapers zero only after GPOS, misplacing stacked marks in fonts whose marks have an advance (Roboto Serif, and all Hebrew vowels in Akkurat Hebrew) - Resolve cursive and mark attachments once, after the advances are final, as HarfBuzz does, instead of after every GPOS stage - Add a test with a Roboto Serif subset (OFL), matching hb-shape
blikblum
reviewed
Oct 21, 2026
| super.applyFeatures(userFeatures, glyphs, advances); | ||
|
|
||
| for (var i = 0; i < this.glyphs.length; i++) { | ||
| fixAttachments(glyphs, positions) { |
Member
There was a problem hiding this comment.
applyFeatures was not being used?
Member
There was a problem hiding this comment.
Never mind. The super class still implements it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observed with real fonts: in Roboto Serif, a diaeresis stacked on an acute (
x́̈) is offset by the acute's advance (fontkit −70, HarfBuzz 5). In our Akkurat Hebrew, every vowel and dot is shifted.hb-shape