Conversation
Adds QueryServiceUdfV1Request/Response Pydantic models (following the SearchIndexChunkingV1Request/Response pattern) plus the REQUEST_TYPE_TO_FEATURE and USE_IN_FEATURE_MAPPING_FOR_CONNECT_API entries needed for cli.py's infer_use_in_feature() to detect and tag this feature at deploy time. No FEATURE_TEMPLATE_MAPPING scaffold yet - see Known Gaps in ADD-INVOKE-OPTION-QueryServiceUdf.md.
|
Thanks for the contribution! It looks like @deepti-sf is an internal user so signing the CLA is not required. However, we need to confirm this. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Function-shaped invoke option support for
QueryServiceUdf, following the existingSearchIndexChunkingpattern:constants.py: addsQueryServiceUdftoUSE_IN_FEATURE_MAPPING_FOR_CONNECT_APIandREQUEST_TYPE_TO_FEATURE, socli.py'sinfer_use_in_feature()detects and tags this feature at deploy time.function/feature_types/query_service_udf.py:QueryServiceUdfV1Request/Response(+Row/Argument/Result) Pydantic models — a synchronous, per-row scalar-in/scalar-out UDF invocation contract.Known gap (not in scope for this PR): no
FEATURE_TEMPLATE_MAPPINGentry yet — that requires a fulltemplates/function/query_service_udf/scaffold (Dockerfile, entrypoint, requirements).Provisional: the request/response shape was authored while the Query Service integration's dispatch mechanism (AlwaysOn vs. code-interpreter branch) is still unresolved on the design side, and may need revision once that lands.
Companion changes:
Test plan
infer_use_in_feature()check with aQueryServiceUdfV1Request/Responsepair