Repository navigation
fix(navbar): point home button to root route - #613
Closed
REAPER2705 wants to merge 1 commit into
Closed
REAPER2705 wants to merge 1 commit into
REAPER2705 wants to merge 1 commit into
Conversation
The Navbar Home button (the FCC logo link) was hard-coded to /classes, which is a teacher-only route. As a result, admins, students, and unauthenticated users were redirected to the error page when they clicked the site logo. This change makes the Home button point to /, the application's actual home page (pages/index.js), regardless of role or auth state, and brings it in line with the other "Menu" links in the codebase. Fixes freeCodeCamp#558
4 tasks done
Member
|
Thank you, @REAPER2705. The navbar on main now links the logo to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Navbar Home button (the FCC logo link) was hard-coded to /classes, which is a teacher-only route. As a result, admins, students, and unauthenticated users were redirected to the error page when they clicked the site logo.
This change makes the Home button point to /, the application's actual home page (pages/index.js), regardless of role or auth state, and brings it in line with the other "Menu" links in the codebase.
Fixes #558
Checklist:
Update index.md)Closes #XXXXX