Repository navigation
feat(lobby): use real game screenshots and logos in the store - #4
Merged
Merged
Conversation
Replace the generated card art with images from the games themselves: - Card covers are screenshots: the studio games' come from the docs/screenshots of their repositories (Urbe, Neo Urbe, Urbe Oasis, Vazante, Sitio), the sandbox games' from their own menu scenes (Horta, Posto, Mata). They ship as WebP under public/covers/. - The featured banner is a full-bleed Vazante battle shot, with the game's logo beside its title. - Card icons are each game's own favicon: Neo Urbe, Sitio, Urbe Oasis and Vazante now use the logos from their repositories (Urbe, Horta, Posto and Mata already did). - The e2e spec checks every card points at its cover and that the cover is served.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Marcel · project thread
Summary
Follow-up to #3. The store cards used generated illustrations; this swaps them for images from the games themselves.
apps/lobby/public/covers/*.webp, ~500 KB total):docs/screenshots/: Urbecity.jpg, Neo Urbecity.jpg, Urbe Oasiscity.png, Vazantebattle.jpg, Sítiofarm.png. Each is cropped to remove the game UI where possible.Test plan
pnpm lint,pnpm typecheck,pnpm test,pnpm buildpnpm test:e2eGenerated by Claude Code