Repository navigation
Conversation
Signed-off-by: CG-5228 <[email protected]>
github-actions
Bot
added
the
documentation
AngeloDanducci
left a comment
AngeloDanducci
left a comment
Contributor
There was a problem hiding this comment.
Thanks for opening this PR @CG-5228
There was a comment asking to be assigned in the original issue prior to this PR being opened - for the time being we will leave this open and defer to the assignee. In the future please leave a comment on the issue asking to be assigned per CONTRIBUTING.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates Step 6 (
Groundedness checks with retrieved context) indocs/docs/tutorials/04-making-agents-reliable.mdso the hallucination check filtershallucination_resultons.get("faithfulness") in ("unfaithful", "partial")rather thans.get("faithfulness") == "No".rag.flag_hallucinated_contentreturns one of four labels ("faithful","partial","unfaithful", or"NA"), so comparing against"No"never matched any sentence.Closes #1771