Repository navigation
DEVOPS-117: Install only Chromium for e2e and bound/retry the apt step - #964
Conversation
The e2e job installed system packages for Chromium, Firefox and WebKit although only Chromium is used. When the runner's Ubuntu mirror serves packages at a few KB/s, that install consumed the full 30-minute job timeout. Install only Chromium and its dependencies, cap the apt step at 8 minutes and retry it once. Refs DEVOPS-117
✅ Deploy Preview for genlayer-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
The first PR run fetched the reduced 32 MB at 83 kB/s and took 7m19s, close to the 8-minute cap. Raise the attempt to 12 minutes, the retry to 10 minutes and the job timeout to 40 minutes so both attempts fit. Refs DEVOPS-117
|
Legatus audit: Approved (commit bfd1e5c) No merge-blocking findings. The workflow implements the ticket’s bounded-retry option and installs only the browser used by the tests. Independently ran Performance limitation: CI on this head passed, but system dependencies took 9m49s. The one-minute target remains unproven; the retry was skipped. LEGATUS-TICKET |
danieljrc888
left a comment
There was a problem hiding this comment.
Approved at the head I reviewed; the requested changes are resolved.
Fixes DEVOPS-117.
What changed
.github/workflows/e2e.yml: the singlenpx playwright install --with-depsstep is replaced by:npx playwright install-deps chromium,timeout-minutes: 12,continue-on-error: true.sudo dpkg --configure -ato repair any interrupted dpkg state, then installs the deps again.timeout-minutes: 10, and this time a failure fails the job.npx playwright install chromium,timeout-minutes: 5.Why:
playwright.config.tsonly defines achromiumproject, butinstall --with-depswithout a browser argument installed Chromium, Firefox and WebKit plus all their system packages. In run 44401638599 that was 181 new packages and 126 MB from the Ubuntu mirror. The package where the run stalled,libmfx1, is not a Chromium dependency. With Playwright 1.55.0 on ubuntu24.04,install-deps --dry-runlists 33 direct packages forchromiumagainst 78 for all browsers. Less download means less exposure to a slow mirror. If the mirror does stall, the job now retries after 12 minutes instead of using up the whole job timeout.How it was tested
actionlint .github/workflows/e2e.ymlpasses.npx [email protected] install-deps --dry-run [chromium]withPLAYWRIGHT_HOST_PLATFORM_OVERRIDE=ubuntu24.04-x64lists 33 packages for Chromium only and 78 for all browsers.e2erun 44422901838 passed (170 tests in 2.7 min). The mirror was slow during that run (us-east-2.ec2.archive.ubuntu.com, 83 kB/s), but the Chromium-only install needed 9 new packages and 32 MB instead of 181 and 126 MB. It finished in 7m19s, where the old command at that speed would have taken about 25 minutes. Because that came close to the original 8-minute cap, a follow-up commit raises the caps.Assumptions
mcr.microsoft.com/playwrightcontainer because its tag must match the locked@playwright/testversion exactly (1.55.0, with dependabot PR chore(deps-dev): bump @playwright/test from 1.55.0 to 1.61.0 in the minor-and-patch group across 1 directory #379 open to bump it). That is easy to break on the next upgrade.timeout-minutesgoes from 30 to 40 so both apt attempts fit: 12 + 10 for the deps, 5 for the browser, about 1 min fornpm ciand about 3 min for build plus tests. 12 minutes for the first attempt leaves headroom for a slow but working mirror (see "How it was tested").Summary by CodeRabbit