Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
|
/run-e2e |
|
E2E status was updated. Follow the current E2E and merge checks on this PR. Detailed diagnostics are available internally. |
danieljrc888
left a comment
There was a problem hiding this comment.
Reviewed at fa10255. This is the split I asked for in #124 and the change itself is correct. Requesting changes only to hold the merge: the base is the frozen v0.19-dev, as the PR body itself says, and genlayer-py has no next development branch yet. The owner decides whether this enters 0.19.0.
What I verified
py.typedis listed inpackage-data, so it ships in the wheel, not only in an editable install.ContractMethodas aTypedDictmatches how it is used (ContractSchema.methodsvalues are plain dicts from the RPC). The previous plain class was never instantiated ingenlayer_py.- The
!in the title does not force a major:releaserc.tomlhasmajor_on_zero = false. - The audit in
docs/TYPING.mdis honest about the 373 strict errors and does not claim a clean SDK.
To fix before it lands, wherever it lands
CHANGELOG.mdis managed by semantic-release inmode = "update"with the<!-- version list -->insertion flag. A hand-writtenUnreleasedsection placed right after the flag will end up below the next generated version entry and stay there labelled as unreleased. Drop the manual section; the squash commit message anddocs/TYPING.mdalready carry the note.docs/TYPING.mdmixes durable content (the audit and known limitations) with release-process text ("not approved for the frozen v0.19-dev / 0.19.0 release", "hold it until"). The second kind is false the moment this merges. Keep it in the PR body only.- The audit pins a base SHA and an error count that will drift. Say so in one line, or add the count to CI as a non-blocking report so the document can be checked.
Release hold and dependency
Do not merge into the frozen v0.19-dev / 0.19.0 train. Hold until the next development branch exists and retarget there, or until the repository owner explicitly approves inclusion. This is the independently reviewed typing prerequisite requested in #124. The feature PR must not merge before this change is approved and lands on the selected development base.
Change
Ship the PEP 561
py.typedmarker explicitly in package data. Installed SDK imports become typed instead ofAny, so downstream consumers can see new type-checking errors even when their code still runs. CorrectContractMethodto describe the schema dictionary with inherited parameter fields. Include an unreleased compatibility note anddocs/TYPING.mdwith the package-wide strict audit and known limitations.This is intentionally independent of the contract generator. PR #124 currently carries identical prerequisite changes for testing; once this prerequisite lands, its diff will disappear from that PR on rebase. Neither PR is authorized to bypass the release freeze.
Validation
uv run pytest tests/unit --disable-warnings -q -m "not testnet": 244 passed, 17 deselected.uv build: wheel and sdist built; inspected the wheel ZIP and verifiedgenlayer_py/py.typedis packaged.mypy --python-executable .venv/bin/python --strict --no-incremental genlayer_pyreports 373 existing errors across 33 files, checking 55 files. This is not a strict-clean claim. Diagnostic counts, examples, consumer impact and reproduction command are recorded indocs/TYPING.md.git diff --checkpasses.Assumptions
Any.Ticket: https://linear.app/genlayer-labs/issue/DXP-537/generate-contract-types-from-schema