Skip to content

macOS: pick the YCbCr matrix per buffer instead of hard-coding BT.709 #1420

Closed

Description

@EtienneLescot

On macOS, sample_yuv in crates/compositor/src/shaders.metal always applies BT.709 coefficients. The buffer marker only selects the range, so a BT.601 VideoToolbox buffer renders with slightly wrong hues. The matrix should come from each buffer's YCbCr matrix attachment.

Pre-existing; spotted by CodeRabbit while reviewing #1408. Refs #1408

Activity

  1. EtienneLescot commented on Oct 30, 2026

    @EtienneLescot
    MemberAuthor

    Fixed by #1421 (merged): the YCbCr matrix is now picked per buffer from its attachments instead of being hard-coded to BT.709.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions