Skip to content

build(npm): Wait for platform packages before bumping lockfile #3451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szokeasaurusrex merged 2 commits into from
Oct 22, 2026
Merged

build(npm): Wait for platform packages before bumping lockfile #3451

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41b0267
build(npm): Wait for platform packages before bumping lockfile
sentry-junior[bot] Oct 21, 2026
322848f
Merge branch 'master' into szokeasaurusrex/post-release-wait-for-npm
szokeasaurusrex Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 34 additions & 2 deletions scripts/post-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,48 @@
# This script is run by Craft after a release is created.
# We currently use it to bump the platform-specific optional dependencies to their new versions
# in the package-lock.json, immediately after a release is created. This is needed for CI to
# pass after the release is created.c
# pass after the release is created.

set -eux
OLD_VERSION="${1}"
NEW_VERSION="${2}"

git checkout master

# Craft can run this script before all platform packages for the new version are visible on npm.
# If we update the lockfile too early, npm drops their versions from it and `npm ci` fails, so
# wait until every optional dependency is available first.
OPTIONAL_DEPENDENCIES=$(node -p "Object.keys(require('./package.json').optionalDependencies).join(' ')")
WAIT_TIMEOUT_SECONDS=1800
WAIT_INTERVAL_SECONDS=30
deadline=$((SECONDS + WAIT_TIMEOUT_SECONDS))

for package in $OPTIONAL_DEPENDENCIES; do
until [ "$(npm view "${package}@${NEW_VERSION}" version --prefer-online 2>/dev/null)" = "${NEW_VERSION}" ]; do
if [ "${SECONDS}" -ge "${deadline}" ]; then
echo "Timed out waiting for ${package}@${NEW_VERSION} to be available on npm" >&2
exit 1
fi
sleep "${WAIT_INTERVAL_SECONDS}"
done
done

# We need to update the package-lock.json to include the new version of the optional dependencies.
npm install --package-lock-only --ignore-scripts
npm install --package-lock-only --ignore-scripts --prefer-online

# Don't push a lockfile that `npm ci` would reject.
NEW_VERSION="${NEW_VERSION}" node -e '
const lock = require("./package-lock.json");
const deps = Object.keys(require("./package.json").optionalDependencies);
const stale = deps.filter((name) => {
const entry = lock.packages?.[`node_modules/${name}`] ?? lock.dependencies?.[name];
return entry?.version !== process.env.NEW_VERSION;
});
if (stale.length > 0) {
console.error(`package-lock.json is missing ${process.env.NEW_VERSION} for: ${stale.join(", ")}`);
process.exit(1);
}
'

git add package-lock.json

Expand Down
Loading